This repository has been archived by the owner on Aug 15, 2024. It is now read-only.
Gadgets that works with naive main gate #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR moves the repo to use the public version of boojum as it’s being fully open sourced.
* Moves to ubuntu-latest. Removes installs. * Adds license check CI.
Fr to Goldilocks fixed
shamatar
reviewed
Aug 9, 2024
src/plonk/circuit/allocated_num.rs
Outdated
| minus_one.negate(); | ||
|
|
||
| let a_minus_b = a.sub(cs, &b)?; | ||
| let a_minus_b_cond = Self::mask(cs, &a_minus_b, &condition)?; |
There was a problem hiding this comment.
You didn't address the fact that such multiplication can be merged with naive gate's multiplication
There was a problem hiding this comment.
It should be addressed by latest commit. @shamatar
shamatar
suggested changes
Aug 13, 2024
|
|
||
| assert_eq!(used_constant, true); | ||
|
|
||
| if used_constant == false { |
There was a problem hiding this comment.
While I'll be checking the layout above, this line looks very invalid (compare to false after assert to true).
Also, you should never allocate constants (this feature is only needed for lookups), and instead add into gate.
Also, starting a sum with allocating zero variable is also not the most rational thing, you can just take first element of intermediate sums
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
This PR adds some gadgets that can works with a main gate that has only 3 variables: qAA + qBB + qABAB + qC*C + qConst
Why ❔
It allowed to keep number of the polynomials in the fflonk implementation smaller so that cheaper evm verification cost.
Checklist
zk fmtandzk lint.