Skip to content

Commit

Permalink
chore: Reduce diff with sync layer stable (zkstack) (#3416)
Browse files Browse the repository at this point in the history
## What ❔

Introduces functions to the zkstack related to Gateway. These are
included into the libraries, but are not included into the users
interface (CLI itself) and a lot of places contain TODO(EVM-927) to
indicate that those are not usable before the Gateway contracts have
been merged.

Also, as per discussions with @sanekmelnikov it is okay that the first
iteration of gateway scripts (esp since those are not usable by the
partners yet) use println instead of spinners that are more commonly
used in zkstack. For this we have a followup task: EVM-928

## Why ❔

<!-- Why are these changes done? What goal do they contribute to? What
are the principles behind them? -->
<!-- Example: PR templates ensure PR reviewers, observers, and future
iterators are in context about the evolution of repos. -->

## Checklist

<!-- Check your PR fulfills the following items. -->
<!-- For draft PRs check the boxes as you complete them. -->

- [ ] PR title corresponds to the body of PR (we generate changelog
entries from PRs).
- [ ] Tests for the changes have been added / updated.
- [ ] Documentation comments have been added / updated.
- [ ] Code has been formatted via `zkstack dev fmt` and `zkstack dev
lint`.
  • Loading branch information
StanislavBreadless authored Jan 3, 2025
1 parent 057dcdb commit 0d83184
Show file tree
Hide file tree
Showing 49 changed files with 3,478 additions and 22 deletions.
2 changes: 1 addition & 1 deletion core/lib/basic_types/src/bytecode.rs
Original file line number Diff line number Diff line change
Expand Up @@ -266,7 +266,7 @@ mod tests {
#[test]
fn preparing_evm_bytecode() {
let bytecode_hash =
BytecodeHash::for_evm_bytecode(PROCESSED_EVM_BYTECODE.len(), &PADDED_EVM_BYTECODE);
BytecodeHash::for_evm_bytecode(PROCESSED_EVM_BYTECODE.len(), PADDED_EVM_BYTECODE);
let prepared = trim_padded_evm_bytecode(bytecode_hash, PADDED_EVM_BYTECODE).unwrap();
assert_eq!(prepared, PROCESSED_EVM_BYTECODE);
}
Expand Down
2 changes: 1 addition & 1 deletion prover/crates/lib/keystore/src/utils.rs
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,7 @@ mod tests {
let filepath = basepath.join("commitments.json");

let text = std::fs::read_to_string(&filepath)
.expect(format!("File at {:?} should be read", filepath).as_str());
.unwrap_or_else(|_| panic!("File at {:?} should be read", filepath));

let commitments = serde_json::from_str::<VkCommitmentsLegacy>(&text)
.expect("Vk commitments should be deserialized correctly");
Expand Down
Loading

0 comments on commit 0d83184

Please sign in to comment.