Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: "Something went wrong" error after converting multi select property to URL #1136

Closed
ogi-m opened this issue Aug 31, 2021 · 3 comments · Fixed by #1174
Closed

Bug: "Something went wrong" error after converting multi select property to URL #1136

ogi-m opened this issue Aug 31, 2021 · 3 comments · Fixed by #1174
Assignees
@sbishel
Labels
Bug Something isn't working QA Verified Bug fix tested and verified by QA
Milestone
v0.9

Comments

@ogi-m
Copy link
Contributor

ogi-m commented Aug 31, 2021

Summary:
Converting multiselect property to URL causes the board to return "Something went wrong" error with no apparent way to fix it. Reopening the board results in the same error.

Steps to reproduce the behavior:

  1. Open boards from Mattermost
  2. Create a card
  3. Create a URL property and add a link to the card
  4. Change the URL property to multi select
  5. Change the property back from multi select to URL

Expected behavior:
"Something went wrong" error is displayed and there's no way to access the board.

Screenshots:
SharedScreenshot

Platform:
Focalboard plugin v0.9.0 RC8 on community-daily (master)
@ogi-m ogi-m added the Bug Something isn't working label Aug 31, 2021
@ogi-m ogi-m modified the milestone: v0.9 Aug 31, 2021
@chenilim chenilim added this to the v0.9 milestone Aug 31, 2021
@chenilim
Copy link
Contributor

We should at least not permanently crash on load.

@sbishel
Copy link
Collaborator

sbishel commented Aug 31, 2021

@ogi-m I am not able to reproduce, tried on main as well as community-daily. We can look at tomorrow.

@sbishel sbishel mentioned this issue Sep 9, 2021
Merged
sbishel added a commit to sbishel/focalboard that referenced this issue Sep 9, 2021
@sbishel
Merge branch 'main' into mattermost-communitygh-1136-property-fix
937741a
sbishel added a commit to sbishel/focalboard that referenced this issue Sep 10, 2021
@sbishel
Merge branch 'mattermost-communitygh-1136-property-fix' of github.com…
492c323 
…:sbishel/focalboard into mattermost-communitygh-1136-property-fix
sbishel added a commit to sbishel/focalboard that referenced this issue Sep 10, 2021
@sbishel
Merge branch 'main' into mattermost-communitygh-1136-property-fix
cf2dfcc
sbishel added a commit to sbishel/focalboard that referenced this issue Sep 10, 2021
@sbishel
Merge branch 'main' into mattermost-communitygh-1136-property-fix
12f7b24
sbishel added a commit that referenced this issue Sep 10, 2021
@sbishel
GH-1136 - fix for when property value is an array (#1174)
730a7af 
* fix for when property value is an array

* remove log statement

* remove async from tests
sbishel added a commit that referenced this issue Sep 14, 2021
@sbishel
GH-1136 - fix for when property value is an array (#1174)
26dba73 
* fix for when property value is an array

* remove log statement

* remove async from tests

(cherry picked from commit 730a7af)
@ogi-m
Copy link
Contributor Author

ogi-m commented Sep 16, 2021

Tested and passed on v0.9.0 RC12

  • not seeing the error anymore
  • property converted back to URL

@ogi-m ogi-m added the QA Verified Bug fix tested and verified by QA label Sep 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sbishel sbishel

Labels
Bug Something isn't working QA Verified Bug fix tested and verified by QA
Projects
None yet
Milestone
v0.9
Development

Successfully merging a pull request may close this issue.

GH-1136 - fix for when property value is an array sbishel/focalboard
3 participants
@sbishel @ogi-m @chenilim