Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Comment are sorted by oldest month first but most recent comment is at the top of the month #1206

Closed
ogi-m opened this issue Sep 14, 2021 · 3 comments · Fixed by #1207
Closed
Assignees
Labels
Bug Something isn't working QA Verified Bug fix tested and verified by QA
Milestone

Comments

@ogi-m
Copy link
Contributor

ogi-m commented Sep 14, 2021

Steps to reproduce the behavior:

  1. Go to Focalboard
  2. Open a card with a long history of comments
  3. Observe the comment sorting

Expected behavior:
Cards are presented from oldest to newest (or newest to oldest?)

Screenshots:
comment_ordering

Platform:

  • plugin v0.9.0 RC9 on community

Additional context:
Note the ordering in the screenshot screenshot, where the oldest month is put on top, but the most recent comment in the month is at the top of the month

  • July 27
  • August 24
  • August 17
  • September 14
  • September 07
@ogi-m ogi-m added the Bug Something isn't working label Sep 14, 2021
@ogi-m
Copy link
Contributor Author

ogi-m commented Sep 14, 2021

These cards are both on community, but the ordering is opposite - one is oldest to newest and the other is newest to oldest.

oldest_to_newest
newest_to_oldest

cc @chenilim

@chenilim
Copy link
Contributor

Thanks @ogi-m. I took a quick look and it seems that the comments are not being sorted (see getCardComments). I think this is a regression, but am not sure. In any case, I believe we should fix this for v0.9 as out-of-order comments can be confusing. The order should be oldest-on-top.

Good news is the fix appears to be straight-forward, and I'll submit a PR for review. cc @sbishel, @jespino.

@chenilim chenilim self-assigned this Sep 14, 2021
@chenilim chenilim added this to the v0.9 milestone Sep 14, 2021
chenilim added a commit that referenced this issue Sep 14, 2021
chenilim added a commit that referenced this issue Sep 14, 2021
* Fix #1206. Sort card comments.

* Remove unused getComments method
chenilim added a commit that referenced this issue Sep 14, 2021
* Fix #1206. Sort card comments.

* Remove unused getComments method
@ogi-m ogi-m added the QA Verified Bug fix tested and verified by QA label Sep 16, 2021
@ogi-m
Copy link
Contributor Author

ogi-m commented Sep 16, 2021

Tested and passed on v0.9.0 RC12 - comments are now sorted from oldest to newest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working QA Verified Bug fix tested and verified by QA
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants