Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-992 Show error if Read-Only board is not available #1022

Merged
merged 4 commits into from
Aug 18, 2021

Conversation

sbishel
Copy link
Collaborator

@sbishel sbishel commented Aug 17, 2021

Summary

Fixes a bug where if a readonly access is revoked, a user is displayed an error banner. The error text already exists in the language files.

Ticket Link

Fixes #992

@sbishel sbishel requested a review from a team as a code owner August 17, 2021 19:15
@sbishel sbishel requested review from hahmadia and harshilsharma63 and removed request for a team August 17, 2021 19:15
@sbishel sbishel added 3: Reviews Complete All reviewers have approved the pull request CherryPick/Approved Meant for the quality or patch release tracked in the milestone labels Aug 18, 2021
@sbishel sbishel added this to the v0.9 milestone Aug 18, 2021
@sbishel sbishel merged commit e5692c9 into mattermost-community:main Aug 18, 2021
@mattermod
Copy link
Contributor

Error trying doing the automated Cherry picking. Please do this manually

fatal: No such remote 'upstream'

+++ Returning you to the main branch and cleaning up.

@mattermod
Copy link
Contributor

Cherry pick is scheduled.

@sbishel sbishel deleted the gh-992-shared-board-error branch August 18, 2021 23:36
sbishel added a commit that referenced this pull request Aug 18, 2021
@sbishel sbishel added CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone and removed CherryPick/Approved Meant for the quality or patch release tracked in the milestone labels Aug 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3: Reviews Complete All reviewers have approved the pull request CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Make page shown after turning off board sharing more descriptive rather than a blank page
4 participants