Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GH-1033] Prevent opening card dialog when link for URL is clicked. #1037

Merged
merged 2 commits into from
Aug 19, 2021
Merged

[GH-1033] Prevent opening card dialog when link for URL is clicked. #1037

merged 2 commits into from
Aug 19, 2021

Conversation

kamre
Copy link
Contributor

@kamre kamre commented Aug 19, 2021

Summary

Stop event propagation for click on the link for URL property.

Ticket Link

Fixes #1033

@kamre kamre requested a review from a team as a code owner August 19, 2021 08:51
@kamre kamre requested review from sbishel and chenilim and removed request for a team August 19, 2021 08:51
@mattermod
Copy link
Contributor

Hello @kamre,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

jespino
jespino approved these changes Aug 19, 2021
View reviewed changes
Copy link
Contributor

@jespino jespino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks @kamre! ✨

@jespino jespino added 3: Reviews Complete All reviewers have approved the pull request CherryPick/Approved Meant for the quality or patch release tracked in the milestone labels Aug 19, 2021
@jespino jespino merged commit 2520d2f into mattermost-community:main Aug 19, 2021
jespino added a commit that referenced this pull request Aug 19, 2021
@kamre @jespino
Prevent opening card dialog when link for URL is clicked. (#1037)
f1574e3 
Co-authored-by: Jesús Espino <jespinog@gmail.com>
@jespino jespino added CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone and removed CherryPick/Approved Meant for the quality or patch release tracked in the milestone labels Aug 19, 2021
@kamre kamre deleted the gh-1033-kanban-card-open-url branch August 24, 2021 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jespino jespino jespino approved these changes

@sbishel sbishel Awaiting requested review from sbishel

@chenilim chenilim Awaiting requested review from chenilim

Assignees
No one assigned
Labels
3: Reviews Complete All reviewers have approved the pull request CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: opening URL from kanban card also opens card dialog
3 participants
@kamre @mattermod @jespino