Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1005 - Updating padding on the share popup #1048

Merged

Conversation

asaadmahmood
Copy link
Contributor

Summary

1005 - Updating padding on the share popup

Ticket Link

#1005

Screenshot

Screenshot 2021-08-19 at 7 58 25 PM

@asaadmahmood asaadmahmood added this to the v0.9 milestone Aug 19, 2021
@asaadmahmood asaadmahmood requested a review from a team as a code owner August 19, 2021 15:01
@asaadmahmood asaadmahmood requested review from sbishel and chenilim and removed request for a team August 19, 2021 15:01
@asaadmahmood asaadmahmood added the 2: Dev Review Requires review by a core committer label Aug 19, 2021
Copy link
Contributor

@chenilim chenilim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@sbishel sbishel added the CherryPick/Approved Meant for the quality or patch release tracked in the milestone label Aug 20, 2021
@asaadmahmood asaadmahmood merged commit 63c2a90 into mattermost-community:main Aug 23, 2021
@mattermod
Copy link
Contributor

Cherry pick is scheduled.

@mattermod
Copy link
Contributor

Error trying doing the automated Cherry picking. Please do this manually

fatal: No such remote 'upstream'

+++ Returning you to the main branch and cleaning up.

@asaadmahmood asaadmahmood deleted the 1005-share-modal-padding branch August 23, 2021 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2: Dev Review Requires review by a core committer CherryPick/Approved Meant for the quality or patch release tracked in the milestone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants