Made calculation options hidden when empty: #1076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harshilsharma63
requested review from
wiggin77,
sbishel,
hahmadia,
a team and
asaadmahmood
and removed request for
a team,
wiggin77 and
sbishel
|
@asaadmahmood can you run this and verify the UX? |
|
@harshilsharma63 For this one, we want to show all the calculate dropdowns if a person is hovering over the row. |
asaadmahmood
requested changes
Aug 24, 2021
|
@asaadmahmood can you take a look at this again? I've made the required changes. |
asaadmahmood
requested changes
Aug 25, 2021
…calboard into table-calculation-defaults
|
@asaadmahmood please take a look again. I've fixed the issue with plugin mode with Mattermost v5.38 and the latest |
harshilsharma63
added a commit
that referenced
this pull request
Aug 30, 2021
* Made calculation options hidden when empty: * WIP * Made calculation row visible on hover * Updated tests * Fixed issue with plugin mode * Fixed a bug where options didn't hide after selecting an option * Updating opacity Co-authored-by: Asaad Mahmood <asaadmahmood@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Displaying table calculation options only when not empty and on hover.
Ticket Link
Fixes #960