Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect the mattermost icon when focalboard is used as a plugin #1185

Merged
merged 2 commits into from
Sep 10, 2021

Conversation

jespino
Copy link
Contributor

@jespino jespino commented Sep 10, 2021

Fixes #1141

@jespino jespino requested a review from a team as a code owner September 10, 2021 18:53
@jespino jespino requested review from wiggin77 and hahmadia and removed request for a team September 10, 2021 18:53
Copy link
Contributor

@wiggin77 wiggin77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jespino jespino added the CherryPick/Approved Meant for the quality or patch release tracked in the milestone label Sep 10, 2021
@jespino jespino merged commit fae2ac1 into mattermost-community:main Sep 10, 2021
@jespino jespino added CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone and removed CherryPick/Approved Meant for the quality or patch release tracked in the milestone labels Sep 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Web app crashes on updateFavicon
2 participants