Updated 0 board to 0 boards (singular vs plural) #1210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harshilsharma63
requested review from
jespino
and removed request for
a team and
jespino
|
/cla |
jespino
reviewed
Sep 15, 2021
|
I was thinking about something more in the line of this: https://codesandbox.io/s/o56w8ywwoz Also you shouldn't concat numbers with strings, not all the languages in the world puts the numbers first, some languages could express that like "Boards 1" for example. so try to include the whole phrase in the translation, including all the parts of the phrase, and avoid concatenations. |
jespino
requested changes
Sep 16, 2021
jespino
requested changes
Sep 16, 2021
harshilsharma63
added a commit
that referenced
this pull request
Sep 22, 2021
* Updated 0 board to 0 boards (singular vs plural * Made text translatable * Used better i18n for singular-plural * Updated tests * Minor fixes * done * Lint fix * Updated tests
harshilsharma63
added
3: Reviews Complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Updated 0 board to 0 boards (singular vs plural)
Ticket Link
Fixes #1200