Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1215. Don't sidebar collapse on Personal Server. #1219

Merged
merged 3 commits into from
Sep 16, 2021

Conversation

chenilim
Copy link
Contributor

Updated the css selector to only hide the collapse-sidebar button when there is a workspace. This might need to be refactored in the future to be more robust.

@chenilim chenilim requested a review from a team as a code owner September 15, 2021 21:54
@chenilim chenilim requested review from wiggin77, hahmadia, harshilsharma63 and a team and removed request for a team, wiggin77 and hahmadia September 15, 2021 21:54
@chenilim chenilim mentioned this pull request Sep 15, 2021
Copy link
Member

@harshilsharma63 harshilsharma63 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chenilim chenilim merged commit 1d4f6c6 into main Sep 16, 2021
@chenilim chenilim deleted the gh1215-sidebar-collapse branch September 16, 2021 15:54
@chenilim chenilim added the CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone label Sep 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants