GH-1244 add setting -webkit-user-select and others for MenuWrapper #1292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbishel
requested review from
ogi-m,
asaadmahmood and
jespino
and removed request for
a team
sbishel
added
2: Dev Review
sbishel
added
the
CherryPick/Candidate
ogi-m
approved these changes
Sep 21, 2021
sbishel
added
3: Reviews Complete
|
Cherry pick is scheduled. |
|
Error trying doing the automated Cherry picking. Please do this manually |
sbishel
added a commit
that referenced
this pull request
Sep 21, 2021
…1292) * add setting -webkit-user-select and others for MenuWrapper * fix lint, disable check
sbishel
added
the
CherryPick/Done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds settings
-webkit-user-select: text; /* Chrome all / Safari all /
-moz-user-select: text; / Firefox all /
-ms-user-select: text; / IE 10+ */
for .MenuWrapper *:firstChild{}
All other places we set
user-select: text;, we set these as well.Related to -
#1094
Ticket Link
Fixes #1244