Fix MySQL migration connection when the DSN doesn't contain any query parameters #557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgdelacroix
force-pushed
the
fix-nil-map-in-mysql-dsn
branch
from
c983b60
to
03a98b4
Compare
chenilim
approved these changes
Jun 10, 2021
jespino
added
3: Reviews Complete
mgdelacroix
added a commit
that referenced
this pull request
Jun 11, 2021
|
Cherry-picked in |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a server panic that would happen in case the server is trying to connect to a MySQL database with no query parameters, when trying to append the
multiStatementsparameter.Based on the server fix applied for this same bug.