Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-965 - Updating global nav right sidebar buttons #983

Merged
merged 4 commits into from
Aug 16, 2021

Conversation

asaadmahmood
Copy link
Contributor

Summary

GH-965 - Updating global nav right sidebar buttons

Ticket Link

#965

Screenshots

Screenshot 2021-08-15 at 5 57 05 PM

@asaadmahmood asaadmahmood requested a review from a team as a code owner August 15, 2021 12:57
@asaadmahmood
Copy link
Contributor Author

@jespino Had to make the buttons classes consistent as we were adding different styles to different buttons that should look and function the same (for the most part).

@asaadmahmood asaadmahmood added 2: Dev Review Requires review by a core committer 2: QA Review Requires review by a QA tester labels Aug 15, 2021
Copy link
Contributor

@jespino jespino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ogi-m ogi-m removed the 2: QA Review Requires review by a QA tester label Aug 16, 2021
@asaadmahmood asaadmahmood merged commit 0675c7e into mattermost-community:main Aug 16, 2021
@asaadmahmood asaadmahmood deleted the GH-965 branch August 16, 2021 18:26
asaadmahmood added a commit that referenced this pull request Aug 16, 2021
* GH-965 - Updating global nav right sidebar buttons

* Updating test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2: Dev Review Requires review by a core committer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants