Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GH-36] specify the subscription is relative to the current channel #63

Merged
merged 1 commit into from
Jul 27, 2020

Conversation

jfrerich
Copy link
Contributor

Summary

This PR updates text to specify the subscription is relative to the current channel.

Ticket Link

Fixes #36

@jfrerich jfrerich added 2: Dev Review Requires review by a core committer 3: QA Review Requires review by a QA tester labels Jul 15, 2020
@jfrerich jfrerich self-assigned this Jul 15, 2020
@codecov-commenter
Copy link

Codecov Report

Merging #63 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #63   +/-   ##
=======================================
  Coverage   29.48%   29.48%           
=======================================
  Files           8        8           
  Lines         234      234           
=======================================
  Hits           69       69           
  Misses        153      153           
  Partials       12       12           
Impacted Files Coverage Δ
server/service/save_subscription.go 31.57% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05cc4cf...7658e42. Read the comment docs.

@jfrerich jfrerich changed the title [GH-36] [GH-36] specify the subscription is relative to the current channel Jul 15, 2020
@hanzei hanzei removed the 2: Dev Review Requires review by a core committer label Jul 22, 2020
@hanzei hanzei added this to the v1.3.0 milestone Jul 22, 2020
Copy link

@DHaussermann DHaussermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and passed

  • Confirmed new text displays correctly
  • No other functional impacts
    LGTM!

@DHaussermann DHaussermann added 4: Reviews Complete All reviewers have approved the pull request and removed 3: QA Review Requires review by a QA tester labels Jul 24, 2020
@jfrerich jfrerich merged commit 09df443 into master Jul 27, 2020
@jfrerich jfrerich deleted the GH-36-clarify-UI-text branch July 27, 2020 18:04
This was referenced Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clarify UI text when subscriptions can be saved because it's being duplicated in a channel
5 participants