Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix linter errors #93

Merged
merged 3 commits into from
Oct 14, 2022
Merged

Fix linter errors #93

merged 3 commits into from
Oct 14, 2022

Conversation

hanzei
Copy link
Collaborator

@hanzei hanzei commented Oct 4, 2022

Summary

Fix linter errors caused by golangci-lint update

Ticket Link

None

@hanzei hanzei requested a review from catalintomai as a code owner October 4, 2022 19:18
@hanzei hanzei added the 2: Dev Review Requires review by a core committer label Oct 4, 2022
@hanzei hanzei requested a review from mickmister October 4, 2022 19:18
@codecov-commenter
Copy link

Codecov Report

Base: 29.70% // Head: 30.29% // Increases project coverage by +0.58% 🎉

Coverage data is based on head (82d03b4) compared to base (2619c30).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #93      +/-   ##
==========================================
+ Coverage   29.70%   30.29%   +0.58%     
==========================================
  Files           9        9              
  Lines         239      241       +2     
==========================================
+ Hits           71       73       +2     
  Misses        156      156              
  Partials       12       12              
Impacted Files Coverage Δ
server/service/notification.go 45.45% <100.00%> (+3.51%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@hanzei hanzei added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core committer labels Oct 14, 2022
@hanzei hanzei added this to the v1.3.0 milestone Oct 14, 2022
@hanzei hanzei merged commit 735ed7a into master Oct 14, 2022
@hanzei hanzei deleted the fix_lint branch October 14, 2022 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants