Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sort memes alphabetically in the list #25

Closed
nathanaelhoun opened this issue Jun 9, 2020 · 1 comment · Fixed by #26
Closed

Sort memes alphabetically in the list #25

nathanaelhoun opened this issue Jun 9, 2020 · 1 comment · Fixed by #26
Assignees
@nathanaelhoun
Labels
Difficulty/1:Easy Easy ticket Help Wanted Community help wanted Tech/Go

Comments

@nathanaelhoun
Copy link
Contributor

Currently, the memes are ordered in the autocomplete feature, but not in the list of meme when /meme is called.

image

It would be handy if they were sorted.

If we implement this change, can we implement the sort directly in getAvailableMemes() (plugin.go) as we always want them sorted ?
@hanzei
Copy link
Contributor

hanzei commented Jun 10, 2020

Thanks for the suggestion @nathanaelhoun 👍

If we implement this change, can we implement the sort directly in getAvailableMemes() (plugin.go) as we always want them sorted ?

That is totally reasonable.

@hanzei hanzei added Difficulty/1:Easy Easy ticket Help Wanted Community help wanted Tech/Go Up For Grabs Ready for help from the community. Removed when someone volunteers labels Jun 10, 2020
@nathanaelhoun nathanaelhoun mentioned this issue Jun 10, 2020
Merged
1 task
@hanzei hanzei removed the Up For Grabs Ready for help from the community. Removed when someone volunteers label Jun 10, 2020
hanzei pushed a commit that referenced this issue Jun 11, 2020
@nathanaelhoun
[GH-25] Always sort memes alphabetically (#26)
eb3ca43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nathanaelhoun nathanaelhoun

Labels
Difficulty/1:Easy Easy ticket Help Wanted Community help wanted Tech/Go
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[GH-25] Always sort memes alphabetically
2 participants
@hanzei @nathanaelhoun