Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add check for SiteURL presence to avoid panic #33

Closed
mickmister opened this issue Aug 20, 2020 · 1 comment · Fixed by #35
Closed

Add check for SiteURL presence to avoid panic #33

mickmister opened this issue Aug 20, 2020 · 1 comment · Fixed by #35
Assignees
@asimsedhain
Labels
Difficulty/1:Easy Easy ticket Good First Issue Suitable for first-time contributors Hacktoberfest Help Wanted Community help wanted Tech/Go Type/Task A general task

Comments

@mickmister
Copy link
Contributor

When the plugin starts up, it tries to access the SiteURL, but this results in a nil pointer panic if the SiteURL is not set. We should instead ensure it is set, and return/log an error during OnActivate to make the error more visible.
@mickmister mickmister added Help Wanted Community help wanted Difficulty/1:Easy Easy ticket Good First Issue Suitable for first-time contributors Hacktoberfest Tech/Go Up For Grabs Ready for help from the community. Removed when someone volunteers Type/Task A general task labels Aug 20, 2020
@asimsedhain
Copy link
Contributor

I would like to take this one.

@asimsedhain asimsedhain mentioned this issue Aug 30, 2020
Merged
@hanzei hanzei removed the Up For Grabs Ready for help from the community. Removed when someone volunteers label Aug 30, 2020
hanzei pushed a commit that referenced this issue Sep 22, 2020
@asimsedhain
[GH-33] fixes nil pointer panic if SiteURL is not set (#35)
495ac38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@asimsedhain asimsedhain

Labels
Difficulty/1:Easy Easy ticket Good First Issue Suitable for first-time contributors Hacktoberfest Help Wanted Community help wanted Tech/Go Type/Task A general task
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[GH-33] fixes nil pointer panic if SiteURL is not set asimsedhain/mattermost-plugin-memes
3 participants
@mickmister @hanzei @asimsedhain