Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added _Prepare the "laser"_ meme #15

Merged
merged 2 commits into from
Mar 9, 2020
Merged

Added _Prepare the "laser"_ meme #15

merged 2 commits into from
Mar 9, 2020

Conversation

apoxa
Copy link
Contributor

@apoxa apoxa commented Mar 5, 2020

Summary

This PR adds the Dr. Evil "Prepare the laser" meme.

Ticket Link

This is a minor improvement without a ticket.

hanzei
hanzei requested changes Mar 5, 2020
View reviewed changes
Copy link
Contributor

@hanzei hanzei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this 👍

It seams like server/memelibrary/assets.go isn't go fmted. Could you please fix this?

@hanzei hanzei added the 2: Dev Review Requires review by a core committer label Mar 5, 2020
@hanzei
Copy link
Contributor

hanzei commented Mar 5, 2020

See https://app.circleci.com/jobs/github/mattermost/mattermost-plugin-memes/34

@apoxa
Copy link
Contributor Author

apoxa commented Mar 5, 2020

I ran "gofmt" on the mentioned file. The checks pass now.

@apoxa apoxa requested a review from hanzei March 9, 2020 09:53
hanzei
hanzei approved these changes Mar 9, 2020
View reviewed changes
Copy link
Contributor

@hanzei hanzei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding more memes 👍

@hanzei hanzei added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core committer labels Mar 9, 2020
@hanzei hanzei merged commit 747f282 into mattermost-community:master Mar 9, 2020
@hanzei hanzei added this to the v1.2.0 milestone Mar 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hanzei hanzei hanzei approved these changes

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Milestone
v1.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@apoxa @hanzei