Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GH-36] Add distracted-boyfriend (#36) #39

Merged
merged 1 commit into from
Dec 2, 2020
Merged

[GH-36] Add distracted-boyfriend (#36) #39

merged 1 commit into from
Dec 2, 2020

Conversation

ravinderj
Copy link
Contributor

Summary

This PR adds the "Distracted Boyfriend" meme.

Ticket Link

#36

@ravinderj ravinderj requested a review from hanzei as a code owner October 22, 2020 04:30
@hanzei hanzei added 2: Dev Review Requires review by a core committer 3: QA Review Requires review by a QA tester labels Oct 22, 2020
@hanzei hanzei linked an issue Oct 22, 2020 that may be closed by this pull request
@hanzei hanzei added this to the v1.4.0 milestone Oct 22, 2020
Copy link
Contributor

@hanzei hanzei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This meme is a gold mine

image

@hanzei hanzei requested a review from larkox October 22, 2020 07:52
Copy link

@larkox larkox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 🎉

@hanzei hanzei removed the 2: Dev Review Requires review by a core committer label Oct 22, 2020
@hanzei hanzei requested a review from DHaussermann October 22, 2020 09:27
@hanzei
Copy link
Contributor

hanzei commented Oct 22, 2020

@DHaussermann I've tested the PR locally. Let me know if you also want to test it.

Copy link

@DHaussermann DHaussermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and passed

  • Meme works as expected
  • Words are position correctly
  • No issues found

LGTM!

Thanks @ravinderj for this addition! Sorry for the delay in testing this.

@DHaussermann DHaussermann added 4: Reviews Complete All reviewers have approved the pull request and removed 3: QA Review Requires review by a QA tester labels Dec 2, 2020
@hanzei hanzei merged commit 8d6344b into mattermost-community:master Dec 2, 2020
@guillaumebriday
Copy link

Awesome ! 🥳 thanks @hanzei !!

@hanzei hanzei mentioned this pull request Dec 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add distracted-boyfriend
5 participants