Fix issue of button not disabled while adding todo without title #249
Conversation
| @@ -143,7 +143,7 @@ export default class AddIssue extends React.PureComponent { | |||
| <React.Fragment> | |||
| <TextareaAutosize | |||
| style={style.textareaResizeMessage} | |||
| placeholder='Enter a title' | |||
| placeholder='Enter a title *' | |||
There was a problem hiding this comment.
We usally want the asterisk to be red or probably error-text class in this case. Also this should be a hint and not placeholder right?
There was a problem hiding this comment.
@mickmister The TextareaAutosize component doesn't have any hint prop in it. Also, the placeholder only supports string type, that's why we were not able to update the color.
Should we add a label element and add stylings to support this?
There was a problem hiding this comment.
That's an external library we're using here. If it's not trivial to change the color of the asterisk, then maybe we just don't use an asterisk here. @asaadmahmood What do you think?
There was a problem hiding this comment.
@asaadmahmood Gentle reminder for this
There was a problem hiding this comment.
@asaadmahmood Gentle reminder for this
There was a problem hiding this comment.
@ayusht2810 We can get rid of the asterik, the button is disabled, its fine that the title needs to be entered.
…lugin-todo into fix_issue_216
hanzei
added
4: Reviews Complete
…termost-community#249) Co-authored-by: raghavaggarwal2308 <raghav.aggarwal@brightscout.com>
Summary
Screenshot
Ticket Link
Fixes #216
Checklist
make testRan test cases and ensured they are passingmake check-styleRan style check and ensured both webapp and server pass the checks