Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update contribution-checklist.md #778

Merged
merged 4 commits into from
Mar 23, 2021
Merged

Update contribution-checklist.md #778

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1f72c02
Update contribution-checklist.md
amyblais Mar 19, 2021
0c2098c
Update code-review.md
amyblais Mar 19, 2021
990b4d5
Update contribution-checklist.md
amyblais Mar 22, 2021
8e1834c
Merge branch 'master' into amyblais-patch-2
amyblais Mar 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions site/content/contribute/getting-started/code-review.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,7 @@ If you are a core committer seeking a review
* [Wait](#if-you-are-awaiting-a-review) for their review to complete before continuing so as to avoid churn if changes are requested.
* Remove the `2: Dev Review` label only when these reviews are done and they accept the changes.
7. After Dev review, assign a [QA tester](/contribute/getting-started/core-committers/#qa-testers).
* Ensure that your PR includes test steps or expected results for QA reference if the QA Test Steps in the Jira ticket have not already been filled in.
* The choice of QA tester is up to you.
- In most cases, choose the QA tester embedded with your team.
- If your change primarily touches another team's codebase, consider their QA tester.
Expand Down
3 changes: 2 additions & 1 deletion site/content/contribute/getting-started/contribution-checklist.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,8 @@ Follow this checklist for submitting a pull request (PR):
6. The PR title begins with the Jira or GitHub Ticket ID (e.g. `[MM-394]` or `[GH-394]`) and summary template is filled out.
7. If your PR adds or changes a RESTful API endpoint, please update the [API documentation](https://github.com/mattermost/mattermost-api-reference).
8. If your PR adds a new plugin API method or hook, please add an example to the [Plugin Starter Template](https://github.com/mattermost/mattermost-plugin-starter-template).
9. Your PR includes basic documentation about the change/addition you're submitting. View our [guidelines](https://handbook.mattermost.com/operations/operations/publishing/publishing-guidelines/voice-tone-and-writing-style-guidelines/submitting-documentation-with-your-pr) for more information about submitting documentation and the review process.
9. If QA review is applicable, your PR includes test steps or expected results.
10. Your PR includes basic documentation about the change/addition you're submitting. View our [guidelines](https://handbook.mattermost.com/operations/operations/publishing/publishing-guidelines/voice-tone-and-writing-style-guidelines/submitting-documentation-with-your-pr) for more information about submitting documentation and the review process.

Once submitted, the automated build process must pass in order for the PR to be accepted. Any errors or failures need to be addressed in order for the PR to be accepted. Next, the PR goes through [code review](https://developers.mattermost.com/contribute/getting-started/code-review/). To learn about the review process for each project, read the `CONTRIBUTING.md` file of that GitHub repository.

Expand Down