Remove OpenTelemetry collector's debug exporter #883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was useful for debugging the collector when setting it up, but it's no longer needed, and if there's any unrelated error (like an agent being down), /var/log/syslog can quickly end up consuming the whole disk. The error logs will still be sent to Loki, so it's not like we're removing useful info for debugging potential errors.
agnivade
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The debug exporter logs whatever payload the collector sends to Loki to the syslog, so it's easier to... well, debug the collector itself :) This was really useful when setting the whole logging system up, but it's no longer needed, and if there's any unrelated error (like an agent being down),
/var/log/syslogcan quickly end up consuming the whole disk (which is what motivated this change). The logs will still be sent to Loki if there's such an error, so it's not like we're removing useful info for debugging potential issues.Ticket Link
--