Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate proper parsing of API errors on webapp side #337

Open
mickmister opened this issue Jul 28, 2020 · 0 comments
Open

Investigate proper parsing of API errors on webapp side #337

mickmister opened this issue Jul 28, 2020 · 0 comments
Labels
Difficulty/1:Easy Easy ticket Good First Issue Suitable for first-time contributors Hacktoberfest Help Wanted Community help wanted Tech/Go Tech/ReactJS Type/Task A general task Up For Grabs Ready for help from the community. Removed when someone volunteers

Comments

@mickmister
Copy link
Member

The plugin's backend is returning error messages as JSON, making it so the frontend displays the errors as JSON in some cases. These code paths should be reviewed to make sure it is rendered properly when we display the errors in different components.

The frontend should be resilient to the possibility that the error is not structured as JSON as well.


Original comment:

This PR is a quick resolution for this issue, however, I believe that it will still need to be further examined and the changes from stringified error to parseable object error should happen in the function that receives the error, not in the method that renders it. Therefore, I believe that still needs to change for this issue to be complete, either in this PR, or if further consistency between error objects across the webapp and the server need to be examined then possibly in the scope of another issue.

Originally posted by @aidapira in #333 (comment)

@mickmister mickmister added Difficulty/1:Easy Easy ticket Good First Issue Suitable for first-time contributors Help Wanted Community help wanted Tech/Go Tech/ReactJS Type/Task A general task Up For Grabs Ready for help from the community. Removed when someone volunteers labels Jul 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Difficulty/1:Easy Easy ticket Good First Issue Suitable for first-time contributors Hacktoberfest Help Wanted Community help wanted Tech/Go Tech/ReactJS Type/Task A general task Up For Grabs Ready for help from the community. Removed when someone volunteers
Projects
None yet
Development

No branches or pull requests

3 participants