GH-318/fix create issue display error showing as JSON #333

aidapira · 2020-07-22T23:45:46Z

Summary

The Create Issue error display showed as JSON and this ticket fixes it to display the message instead.

Ticket Link

#318

hanzei

LGTM. Thanks for the quick contribution 👍

larkox

Looks great. Thanks! 🎉

codecov-commenter · 2020-07-23T13:32:13Z

Codecov Report

Merging #333 (09f8181) into master (eda6f9a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #333   +/-   ##
=======================================
  Coverage   19.35%   19.35%           
=======================================
  Files          11       11           
  Lines        2770     2770           
=======================================
  Hits          536      536           
  Misses       2196     2196           
  Partials       38       38

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eda6f9a...09f8181. Read the comment docs.

aidapira · 2020-07-28T17:29:40Z

Thanks @hanzei, @larkox, and @mickmister for reviewing this PR. This PR is a quick resolution for this issue, however, I believe that it will still need to be further examined and the changes from stringified error to parseable object error should happen in the function that receives the error, not in the method that renders it. Therefore, I believe that still needs to change for this issue to be complete, either in this PR, or if further consistency between error objects across the webapp and the server need to be examined then possibly in the scope of another issue.

mickmister · 2020-07-28T19:05:50Z

Therefore, I believe that still needs to change for this issue to be complete, either in this PR, or if further consistency between error objects across the webapp and the server need to be examined then possibly in the scope of another issue.

This fix seems fine for the scope of this ticket. Created a follow up ticket to address the broader issue #337

mickmister · 2020-07-31T00:35:00Z

webapp/src/components/modals/create_issue/create_issue.jsx

@@ -124,7 +124,7 @@ export default class CreateIssueModal extends PureComponent {
        if (error) {
            submitError = (
                <p className='help-text error-text'>
-                    <span>{error}</span>
+                    <span>{JSON.parse(error).message}</span>


I'm concerned that error may sometimes be a string here. Maybe we should protect against that?

If it is the case that error is a string, then this will error out and cause WSOD. I suggest applying a fix in this component's handleCreate method instead of the render function, similar to the fix in the Attach Comment to Issue Modal:

mattermost-plugin-github/webapp/src/components/modals/attach_comment_to_issue/attach_comment_to_issue.jsx

Lines 61 to 66 in bc5a371

let errMessage = created.error.message;

if (created.error.response &&

created.error.response.body &&

created.error.response.body.message) {

errMessage = created.error.response.body.message;

}

@aidapira What are your thoughts on moving the fix out of the render function and into handleCreate?

Hi @mickmister, that sounds like a great idea. Please give me a few days and I will commit the updates based on your comment.

DHaussermann

Tested and passed

Reproduce this by attempting to create an issue in a repository where issue creation has been disabled
Applied this PR and the json error is now replaced with friendlier failed to create issue: Unknown status code 410
Briefly regression tested the modal
LGTM!

Thanks @aidapira for this enhancement! Much appreciated.

mattermod · 2020-08-17T01:00:42Z

This issue has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

/cc @jasonblais @hanzei

hanzei · 2020-08-17T08:39:44Z

@aidapira Do you have questions about the feedback above? #333 (comment) Let me know if you need any help.

aidapira · 2020-08-18T05:34:51Z

@aidapira Do you have questions about the feedback above? #333 (comment) Let me know if you need any help.

@hanzei Thank you so much for pointing my attention to @mickmister's comment. I will let you know after I give it a try!

hanzei · 2020-08-18T09:44:59Z

@aidapira Awesome, looking forward to your response 👍

hanzei · 2020-09-28T21:50:20Z

@aidapira Thanks for updating the PR 👍 Heads up that there is a merge conflict to resolve.

mickmister

Thanks @aidapira! Looks good, I just have two last requests

webapp/src/components/modals/attach_comment_to_issue/attach_comment_to_issue.jsx

mattermod · 2020-10-26T01:00:58Z

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

/cc @jasonblais @jfrerich

jfrerich · 2020-10-26T21:25:07Z

Hi @aidapira! It seems that you are really close to completing this PR. Do you need any further assistance from one of our developers? There is also a merge conflict that will need to be addressed.

hanzei · 2021-03-16T20:01:42Z

@aidapira Are you planing to continue working on this PR?
Please note that we will close this PR after another 10 days of inactivity. If you don't object, other contributors might complete this PR for you.

aidapira · 2021-03-20T23:19:04Z

@aidapira Are you planing to continue working on this PR?
Please note that we will close this PR after another 10 days of inactivity. If you don't object, other contributors might complete this PR for you.

Hi @hanzei, thanks for mentioning me and giving me some time to complete this PR. I'm working on completing it now and would expect an update within the next week.

…url and remove extra code on parse error

mickmister

LGTM 👍 Thanks @aidapira!

mickmister · 2021-03-23T02:03:54Z

@aidapira It looks like there are some conflicts with one of the files. Are you able to resolve the conflicts with master?

mickmister · 2021-04-13T14:43:11Z

Hi @aidapira, it looks like there is one remaining linting error here:

/home/circleci/project/webapp/src/components/modals/create_issue/create_issue.jsx
  91:34  error  Missing trailing comma  comma-dangle

webapp/src/components/modals/create_issue/create_issue.jsx

mickmister

Thanks for the contribution @aidapira!

mattermostGH-318/fix create issue display error showing as JSON

279db90

aidapira requested a review from hanzei as a code owner July 22, 2020 23:45

hanzei linked an issue Jul 23, 2020 that may be closed by this pull request

The error message display in the Create Issue modal displays as JSON #318

Closed

hanzei added 2: Dev Review Requires review by a core committer 3: QA Review Requires review by a QA tester labels Jul 23, 2020

hanzei approved these changes Jul 23, 2020

View reviewed changes

hanzei requested a review from larkox July 23, 2020 09:23

larkox approved these changes Jul 23, 2020

View reviewed changes

larkox removed the 2: Dev Review Requires review by a core committer label Jul 23, 2020

larkox requested a review from DHaussermann July 23, 2020 11:53

Merge branch 'master' into mattermostGH-318-create-issue-display-error

ad7f5ba

mickmister mentioned this pull request Jul 28, 2020

Investigate proper parsing of API errors on webapp side #337

Open

mickmister reviewed Jul 31, 2020

View reviewed changes

DHaussermann approved these changes Aug 3, 2020

View reviewed changes

DHaussermann added 4: Reviews Complete All reviewers have approved the pull request and removed 3: QA Review Requires review by a QA tester labels Aug 3, 2020

hanzei added this to the v1.1.0 milestone Aug 3, 2020

mickmister added the Awaiting Submitter Action Blocked on the author label Aug 5, 2020

hanzei added 2: Dev Review Requires review by a core committer and removed 4: Reviews Complete All reviewers have approved the pull request labels Aug 5, 2020

hanzei modified the milestones: v1.1.0, v1.2.0 Aug 6, 2020

mattermod added the Lifecycle/1:stale label Aug 17, 2020

mattermostGH-318/Response to commit errors

4479d20

hanzei added the Awaiting Submitter Action Blocked on the author label Oct 5, 2020

mickmister requested changes Oct 5, 2020

View reviewed changes

webapp/src/components/modals/attach_comment_to_issue/attach_comment_to_issue.jsx Outdated Show resolved Hide resolved

webapp/src/components/modals/attach_comment_to_issue/attach_comment_to_issue.jsx Outdated Show resolved Hide resolved

mattermod added the Lifecycle/1:stale label Oct 26, 2020

hanzei added Lifecycle/2:inactive and removed 2: Dev Review Requires review by a core committer 3: QA Review Requires review by a QA tester labels Mar 16, 2021

mattermostGH-318/respond to reviewer comments to clear import syntax …

81741f1

…url and remove extra code on parse error

aidapira requested review from mickmister and hanzei March 23, 2021 00:23

mickmister approved these changes Mar 23, 2021

View reviewed changes

aidapira added 3 commits March 23, 2021 18:30

mattermostGH-13/resolving merge conflicts

eb42649

mattermostGH-318/resolve conflict

08b5ce5

GH318/Change fetching created using await instead of promise

df52f25

hanzei removed their request for review March 29, 2021 11:50

mickmister reviewed Apr 26, 2021

View reviewed changes

webapp/src/components/modals/create_issue/create_issue.jsx Outdated Show resolved Hide resolved

Update webapp/src/components/modals/create_issue/create_issue.jsx

92e0e3f

mickmister removed the Awaiting Submitter Action Blocked on the author label May 18, 2021

mickmister approved these changes May 18, 2021

View reviewed changes

remove unintentional changes

09f8181

mickmister merged commit 6957b7f into mattermost:master May 18, 2021

hanzei removed the Lifecycle/1:stale label Jan 4, 2022

hanzei mentioned this pull request Jan 4, 2022

Poor UX when trying to create an issue if the repository does not permit it mattermost-community/mattermost-plugin-bitbucket#55

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

GH-318/fix create issue display error showing as JSON #333

GH-318/fix create issue display error showing as JSON #333

aidapira commented Jul 22, 2020

hanzei left a comment

larkox left a comment

codecov-commenter commented Jul 23, 2020 •

edited

Loading

aidapira commented Jul 28, 2020

mickmister commented Jul 28, 2020

mickmister Jul 31, 2020

mickmister Aug 3, 2020

mickmister Aug 3, 2020

aidapira Aug 18, 2020

DHaussermann left a comment

mattermod commented Aug 17, 2020

hanzei commented Aug 17, 2020

aidapira commented Aug 18, 2020

hanzei commented Aug 18, 2020

hanzei commented Sep 28, 2020

mickmister left a comment

mattermod commented Oct 26, 2020

jfrerich commented Oct 26, 2020 •

edited

Loading

hanzei commented Mar 16, 2021

aidapira commented Mar 20, 2021

mickmister left a comment

mickmister commented Mar 23, 2021

mickmister commented Apr 13, 2021

mickmister left a comment

	let errMessage = created.error.message;
	if (created.error.response &&
	created.error.response.body &&
	created.error.response.body.message) {
	errMessage = created.error.response.body.message;
	}

GH-318/fix create issue display error showing as JSON #333

GH-318/fix create issue display error showing as JSON #333

Conversation

aidapira commented Jul 22, 2020

Summary

Ticket Link

hanzei left a comment

Choose a reason for hiding this comment

larkox left a comment

Choose a reason for hiding this comment

codecov-commenter commented Jul 23, 2020 • edited Loading

Codecov Report

aidapira commented Jul 28, 2020

mickmister commented Jul 28, 2020

mickmister Jul 31, 2020

Choose a reason for hiding this comment

mickmister Aug 3, 2020

Choose a reason for hiding this comment

mickmister Aug 3, 2020

Choose a reason for hiding this comment

aidapira Aug 18, 2020

Choose a reason for hiding this comment

DHaussermann left a comment

Choose a reason for hiding this comment

mattermod commented Aug 17, 2020

hanzei commented Aug 17, 2020

aidapira commented Aug 18, 2020

hanzei commented Aug 18, 2020

hanzei commented Sep 28, 2020

mickmister left a comment

Choose a reason for hiding this comment

mattermod commented Oct 26, 2020

jfrerich commented Oct 26, 2020 • edited Loading

hanzei commented Mar 16, 2021

aidapira commented Mar 20, 2021

mickmister left a comment

Choose a reason for hiding this comment

mickmister commented Mar 23, 2021

mickmister commented Apr 13, 2021

mickmister left a comment

Choose a reason for hiding this comment

codecov-commenter commented Jul 23, 2020 •

edited

Loading

jfrerich commented Oct 26, 2020 •

edited

Loading