Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There should be a auto suggestion for a exclude Command #507

Closed
dipak-demansol opened this issue Nov 1, 2021 · 13 comments
Closed

There should be a auto suggestion for a exclude Command #507

dipak-demansol opened this issue Nov 1, 2021 · 13 comments
Labels
Difficulty/1:Easy Easy ticket Good First Issue Suitable for first-time contributors Help Wanted Community help wanted Tech/Go Type/Bug Something isn't working

Comments

@dipak-demansol
Copy link

dipak-demansol commented Nov 1, 2021

There should be a auto suggestion for a exclude Command because without auto suggestion The user will never know that there is a functionality like exclude.

related to #505

There should be a auto suggetion for a exclude Command

@dipak-demansol dipak-demansol added Triage Type/Bug Something isn't working labels Nov 1, 2021
@catalintomai catalintomai added this to the v2.2.0 milestone Nov 1, 2021
@hanzei hanzei added Difficulty/1:Easy Easy ticket Good First Issue Suitable for first-time contributors Help Wanted Community help wanted Tech/Go Up For Grabs Ready for help from the community. Removed when someone volunteers labels Nov 2, 2021
@hanzei
Copy link
Contributor

hanzei commented Nov 8, 2021

Good catch @dipak-demansol 👍 Made this a HW.

@dipak-demansol
Copy link
Author

dipak-demansol commented Dec 8, 2021

@hanzei Whats your thought on this?

Need to improve User experience
1) After using /github help,The user will get the description of all command so in that need text improvement so user easily understand how to use this command, why need this? because before exclude need to add only ORG or Owner name and then need to use the --exclude and then need to add the Owner/repo name then only this will work so its best you add this line in the help description so user easily understand how to use this, /github subscriptions add owner --exclude owner[/repo]

 2) in the auto suggestion we can add option like this (this will be more easy to understand)
     (2.1)
      **menu title                      --exclude [owner/repo]
      menu description            ex :- /github subscriptions add owner --exclude owner[/repo]**
                                                          **or** 
     (2.2)
                    **in the future list you can add like --exclude owner[/repo]**

@dipak-demansol
Copy link
Author

dipak-demansol commented Dec 8, 2021

@sanjaydemansol about the point 2, need to do the 2.1 or 2.2 to improve the user-experience.

@hanzei
Copy link
Contributor

hanzei commented Dec 9, 2021

  1. Unfortunately, the autocomplete is static. Hence, there is no way to make the flags depend of if the user did input an org or a repo. The description has to make it clear how to use the flag.

@dipak-demansol
Copy link
Author

  1. Unfortunately, the autocomplete is static. Hence, there is no way to make the flags depend of if the user did input an org or a repo. The description has to make it clear how to use the flag.

so we ignore the point 2 and do the text changes as per the point 1, right?

@hanzei
Copy link
Contributor

hanzei commented Dec 10, 2021

I'm not sure I'm getting your suggestion in 2). There should still be an autocomplete flag for exclude.

@dipak-demansol
Copy link
Author

(2.1)

about the 2.1, we can add Command like this for exclude

33

                                           **OR** 

About 2.2, We can add this text --exclude owner[/repo] here, pls see the image.
55

@hanzei
Copy link
Contributor

hanzei commented Dec 13, 2021

Got it, thanks for the screenshot @dipak-demansol 👍

2.1. What would you add in 2.1? What information is missing in /connect?

2.2. The --exclude flag should not be part of the features list, but instead it's own autocomplete item.

@dipak-demansol
Copy link
Author

--exclude [owner/repo]

i suggestion was we can add this command "--exclude [owner/repo]", same as /connect.

@hanzei
Copy link
Contributor

hanzei commented Dec 15, 2021

What do you mean with "same as /connect."?

@dipak-demansol
Copy link
Author

What do you mean with "same as /connect."?

when i type "/github subscribe add dipak-demansol" then i add space then i should get the exclude command in the auto suggestion.

@dipak-demansol
Copy link
Author

dipak-demansol commented Dec 15, 2021

What do you mean with "same as /connect."?

we can connect on call, i will take only 5 minutes to explain exactly what i'm talking about.

@hanzei hanzei removed this from the v2.2.0 milestone Sep 20, 2022
@raghavaggarwal2308
Copy link
Contributor

@mickmister I think this issue was created after the previous PR #457 which was reverted

This issue does not exist after the latest changes with #683. Can we close this issue?
image

@hanzei hanzei removed the Up For Grabs Ready for help from the community. Removed when someone volunteers label Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Difficulty/1:Easy Easy ticket Good First Issue Suitable for first-time contributors Help Wanted Community help wanted Tech/Go Type/Bug Something isn't working
Projects
Development

No branches or pull requests

5 participants