-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GH-418]: Fixed issue #418 'Added --exclude option to subscriptions command'. #683
Conversation
* [MI-2874]: Added --exclude option to subscriptions commandx * [MI-2874]:Updated the read me files * [MI-2874]:Fixed review comments * [MI-2874]:Fixed review comments --------- Co-authored-by: Kshitij Katiyar <kshitij.katiyar@brightscout.com>
Hello @Kshitij-Katiyar, Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here. |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #683 +/- ##
==========================================
- Coverage 15.63% 15.57% -0.07%
==========================================
Files 15 15
Lines 5518 5541 +23
==========================================
Hits 863 863
- Misses 4613 4636 +23
Partials 42 42
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work 👍
@Kshitij-Katiyar Merging |
This PR has been automatically labelled "stale" because it hasn't had recent activity. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested "--exclude" flag in subscriptions and it's working fine, LGTM.
Summary
Currently, subscriptions allow adding repositories or an organization to a subscription. Added an additional --exclude flag that will allow excluding repositories from the webhook notification.
Issue #418