-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
After subscribing the event, need to display event name with the success message. #513
Comments
Have a user message being posted to the channel the user is in. |
NO, that success message is only visible for that user and for the same channel, in other channel that message will not visible. |
@catalintomai Currently when i subscribe some channel by using this command as /github subscriptions add dipak-demansol/sample1 issues,pulls then i'm getting this system generated message as Successfully subscribed to sample1. but message should be like this Successfully subscribed to sample1 : issues, pulls |
@dipak-demansol are you looking for this feature |
Yes sir. |
The point that @catalintomai wanted to made, is that as part of this ticket not only should the events be named in the message, but I should also get posted in the channel and not as an ephemeral post. |
@hanzei just to be on same page , when you user subscribe to a repo , he should get a message what does it actually mean i see there is a message but a ephemeral post can you explain it bit, will be okey to connect offline or on sync up call |
When a user adds a subscription, there should be a bot message in the channel stating for which repo/org the subscription was created and to which events it subscribes. |
#517 can be used as a staring point |
…gin (#25) * [MI-2904]:Fixed issue mattermost#512 and mattermost#513 on github plugin * [MI-2904]:Fixed review comments * [MI-2904]:Fixed review comments
…cription success messages' (#661) * [MI-2904]:Fixed issue #512 and #513 on github plugin (#25) * [MI-2904]:Fixed issue #512 and #513 on github plugin * [MI-2904]:Fixed review comments * [MI-2904]:Fixed review comments * [MI-2928]:Fixed review comments for issue 512 and 513 on github plugin (#26) * [MM-512,513]:Fixed review comments given by mm team * [MM-512,513]:Updated user error msg * [MM-512,513]:Fixed lint errors * [MM-512,513]: reverted package-lock.json changes * Fixed lint. --------- Co-authored-by: Abhishek Verma <abhishek.verma@brightscout.com>
why its required :- after subscribing some event user is getting this message as "Successfully subscribed to test3." but with the success message we can also Print the events that user just subscribed, if we Print that then after subscription user will know that what he just subscribed and don't need to use another command to see that what just he subscribed.
if you fix this then also pls fix this one #512
The text was updated successfully, but these errors were encountered: