Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code previews only work for commit hashes, not for branches #670

Closed
ThiefMaster opened this issue Apr 13, 2023 · 0 comments · Fixed by #767
Closed

Code previews only work for commit hashes, not for branches #670

ThiefMaster opened this issue Apr 13, 2023 · 0 comments · Fixed by #767
Labels
Type/Enhancement New feature or improvement of existing feature
Milestone
v2.4.0

Comments

@ThiefMaster
Copy link

A link pointing to .../master/... doesn't trigger the code preview for example.

A nice solution to prevent later changes would be to automatically look up the current commit the branch/tag points to and then saving that commit hash somehow to use for the preview.
@hanzei hanzei added the Type/Enhancement New feature or improvement of existing feature label May 21, 2023
@Kshitij-Katiyar Kshitij-Katiyar added this to the v2.3.0 milestone Oct 5, 2023
@raghavaggarwal2308 raghavaggarwal2308 mentioned this issue Apr 9, 2024
Merged
@raghavaggarwal2308 raghavaggarwal2308 modified the milestones: v2.3.0, v2.4.0 Jul 9, 2024
raghavaggarwal2308 added a commit that referenced this issue Jul 29, 2024
@raghavaggarwal2308 @Kshitij-Katiyar
[GH-670] Fix issue: Code previews not working for branches (#767)
133f527 
* [MM-362] Fix issue: Code previews not working for branches

* [MM-670]: added support for hyphen in branch name for code preview of permalink

* [MM-670]: fixed the testcase for permalink.go

* [MM-670]: Updated the testcase for code preview using branch name with various charecter

---------

Co-authored-by: kshitij katiyar <kshitij.katiyar@brightscout.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type/Enhancement New feature or improvement of existing feature
Projects
None yet
Milestone
v2.4.0
Development

Successfully merging a pull request may close this issue.

[GH-670] Fix issue: Code previews not working for branches mattermost/mattermost-plugin-github
4 participants
@ThiefMaster @hanzei @raghavaggarwal2308 @Kshitij-Katiyar