-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pull Request Reviews are not posted. #686
Labels
Type/Bug
Something isn't working
Comments
Kshitij-Katiyar
added a commit
to Brightscout/mattermost-plugin-github
that referenced
this issue
Aug 11, 2023
Kshitij-Katiyar
added a commit
to Brightscout/mattermost-plugin-github
that referenced
this issue
Aug 14, 2023
Thank you. <3 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When Pull Request Reviews are
submitted
(Comment, Approve, Change Requested), no message appears in the subscribed channelReproduction steps:
Logging
When enabling DEBUG logging, the following line appears:
Investigation:
Looking at webhook.go:827, the review state is checked against uppercase
APPROVED
, but it seems to be lowercaseapproved
. Same goes fort the other PR review actions.Extras
Here is the payload from the github webhook settings page (cleared private data):
As one can see, github sends
review.state = "approved"
(lowercase).The text was updated successfully, but these errors were encountered: