Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support --include-only-org-members for channel subscriptions #744

Open
mickmister opened this issue Feb 13, 2024 · 2 comments · May be fixed by #797 or mattermost/docs#7244
Open

Support --include-only-org-members for channel subscriptions #744

mickmister opened this issue Feb 13, 2024 · 2 comments · May be fixed by #797 or mattermost/docs#7244
Assignees
@burakcakirel
Labels
Difficulty/1:Easy Easy ticket Good First Issue Suitable for first-time contributors Help Wanted Community help wanted Tech/Go Type/Enhancement New feature or improvement of existing feature

Comments

@mickmister
Copy link
Contributor

Currently there is a --exclude-org-member flag that allows a subscription to filter out any events caused by a member of the plugin's configured org. It would be great to be able to do the opposite, and include only org members in a given subscription
@mickmister mickmister added Help Wanted Community help wanted Up For Grabs Ready for help from the community. Removed when someone volunteers Tech/Go Good First Issue Suitable for first-time contributors Difficulty/1:Easy Easy ticket Type/Enhancement New feature or improvement of existing feature labels Feb 13, 2024
@burakcakirel
Copy link

Hello @mickmister, I'd like to work on this.

@mickmister mickmister removed the Up For Grabs Ready for help from the community. Removed when someone volunteers label May 13, 2024
@mickmister
Copy link
Contributor Author

Awesome @burakcakirel!! Thank you!

@burakcakirel burakcakirel linked a pull request Jul 3, 2024 that will close this issue
Open
burakcakirel added a commit to burakcakirel/mattermost-plugin-github that referenced this issue Jul 3, 2024
@burakcakirel
Merge branch 'refs/heads/master' into mattermostgh-744-support-includ…
8cd0e9a 
…e-only-org-members

# Conflicts:
#	README.md
#	server/plugin/webhook.go
@burakcakirel burakcakirel linked a pull request Jul 3, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@burakcakirel burakcakirel

Labels
Difficulty/1:Easy Easy ticket Good First Issue Suitable for first-time contributors Help Wanted Community help wanted Tech/Go Type/Enhancement New feature or improvement of existing feature
Projects
None yet
Milestone
No milestone
2 participants
@burakcakirel @mickmister