Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replacing apache.com/thrift with github.com to solve network issue when building #122

Merged
merged 2 commits into from
Sep 12, 2019

Conversation

niklabh
Copy link
Contributor

@niklabh niklabh commented Sep 11, 2019

Summary

go mudule unable to access git.apache.org as it is timing out. Replacing it with github.com for thrift.

Issue

mattermost/mattermost#12125

@hanzei hanzei added the 2: Dev Review Requires review by a core committer label Sep 11, 2019
Copy link
Contributor

@hanzei hanzei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this 👍

go.mod Show resolved Hide resolved
@hanzei
Copy link
Contributor

hanzei commented Sep 11, 2019

Please also see mattermost/mattermost#12146

@hanzei hanzei added this to the v0.11.0 milestone Sep 11, 2019
@hanzei hanzei added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core committer labels Sep 12, 2019
@hanzei hanzei merged commit 2b1c8d2 into mattermost:master Sep 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants