Avoided panic on empty body of PR and Issue

[abdulsmapara]

Summary

• Checks whether pointer to the body of PR/Issue is nil before accessing it to avoid panic.
• I have assumed that result obtained by calling Get() on PR/Issue is never nil as other functions do not check this condition (Reference: https://github.com/mattermost/mattermost-plugin-github/blob/master/server/plugin/api.go#L489).

Ticket Link

Extension to the PR #326 that fixes #312

[codecov-commenter]

Codecov Report

Merging #351 into master will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #351      +/-   ##
==========================================
- Coverage   21.68%   21.66%   -0.02%     
==========================================
  Files          10       10              
  Lines        2638     2640       +2     
==========================================
  Hits          572      572              
- Misses       2029     2031       +2     
  Partials       37       37              

Impacted Files	Coverage Δ
server/plugin/api.go	8.73% <0.00%> (-0.03%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a4792f...d261f52. Read the comment docs.

[hanzei]

Thanks for the fix 👍

Indeed, result should never be nil if err != nil

[larkox]

LGTM! Thanks for the fix!

[hanzei]

@DHaussermann I'm happy to review this one myself, given that I also found the bug.

[DHaussermann]

@hanzei or @larkox If you have a bit of time, could one of you peer-test this PR using the peer testing process documented here https://mattermost.atlassian.net/wiki/spaces/INT/pages/619937892/Peer+Testing+Process

[hanzei]

Scope

Empty body of PRs and issues should not crash plugin

Testing notes

• Links to PRs and issues with empty bodies don't crash the plugin any longer
• Tooltip for these are correctly shown
• Removing of HTML comments still work

Follow-up concerns

None

[hanzei]

@DHaussermann ☝️

[DHaussermann]

Thanks for testing @hanzei. Follow-up on this So I can make sure there is appropriate release testing in place. How is it possible to create a PR where Body is empty i.e. nil?
I have tested with and an empty description field but this is different?

[hanzei]

/update-branch

[hanzei]

@DHaussermann E.g. mattermost/mattermost-plugin-demo#112 is a PR without a description, which would cause a panic. I haven't found an issue to reproduce the issue for far.

[DHaussermann]

Tested and passed

Thanks @hanzei for peer testing. I have added release coverage for the end to end testing.

Huge thanks @abdulsmapara for fixing this! Much appreciated.