Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use issue icon in RHS #376

Merged
merged 3 commits into from
Oct 1, 2020
Merged

Use issue icon in RHS #376

merged 3 commits into from
Oct 1, 2020

Conversation

hanzei
Copy link
Contributor

@hanzei hanzei commented Sep 25, 2020

Summary

Before After
Screenshot from 2020-09-25 20-29-24 Screenshot from 2020-09-25 20-26-52
Screenshot from 2020-09-25 20-29-49 Screenshot from 2020-09-25 20-27-08

Ticket Link

Fixes #375

@hanzei hanzei added 2: Dev Review Requires review by a core committer 3: QA Review Requires review by a QA tester 1: UX Review Requires review by a UX Designer labels Sep 25, 2020
@hanzei hanzei added this to the v2.0.0 milestone Sep 25, 2020
@codecov-commenter
Copy link

codecov-commenter commented Sep 25, 2020

Codecov Report

Merging #376 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #376   +/-   ##
=======================================
  Coverage   19.67%   19.67%           
=======================================
  Files          11       11           
  Lines        2709     2709           
=======================================
  Hits          533      533           
  Misses       2138     2138           
  Partials       38       38           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32a922e...cc505b4. Read the comment docs.

@hanzei hanzei removed the 1: UX Review Requires review by a UX Designer label Sep 25, 2020
@hanzei hanzei mentioned this pull request Sep 25, 2020
@hanzei hanzei mentioned this pull request Sep 25, 2020
17 tasks
Copy link
Contributor

@larkox larkox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just two nits.

@hanzei hanzei removed the 2: Dev Review Requires review by a core committer label Sep 28, 2020
Copy link

@DHaussermann DHaussermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and passed

  • Confirmed the icons have been replaced as expected
  • Link to Issue and PR are functional to navigate to their respective issues
  • Tested with multiple themes to ensure no updates needed here

LGTM!

Thanks @hanzei this is a nice little piece of polish!

@DHaussermann DHaussermann added 4: Reviews Complete All reviewers have approved the pull request and removed 3: QA Review Requires review by a QA tester labels Sep 30, 2020
@hanzei hanzei merged commit a5ad5fd into master Oct 1, 2020
@hanzei hanzei deleted the 375_issue-icon branch October 1, 2020 07:03
@hanzei hanzei mentioned this pull request Nov 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Assignments tab shows PR icon for issues
6 participants