-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Connect to private repositories by default #448
Conversation
Hello @manojmalik20, Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for the addition 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
@DHaussermann Can you please review this PR? |
Friendly ping @DHaussermann for review. |
Very sorry for the delay on this @manojmalik20 I should finally be able to get to this today 👍 |
/update-branch |
We don't have permissions to update this PR, please contact the submitter to apply the update. |
Codecov Report
@@ Coverage Diff @@
## master #448 +/- ##
=======================================
Coverage 19.65% 19.66%
=======================================
Files 11 11
Lines 2727 2741 +14
=======================================
+ Hits 536 539 +3
- Misses 2151 2162 +11
Partials 40 40
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and passed
Connect to private Repositories by default
functions as expected with no need to appendprivate
- When enabled the redundant
private
parameter is removed from the auto complete as expected - Flag to enable / disable this feature works as expected
- Flag is
false
by default to ensure seamless upgrade - Tested on desktop and browser
LGTM!
Huge thanks @manojmalik20 for this enhancement.
Summary
private
Screenshots