Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connect to private repositories by default #448

Merged
merged 6 commits into from
Jun 14, 2021

Conversation

manojmalik20
Copy link
Contributor

Summary

  • Added the feature to connect to private repositories by slash command without explicitly mentioning private
  • Added a setting in the plugin to enable/disable this feature

Screenshots

image

@manojmalik20 manojmalik20 requested a review from hanzei as a code owner May 31, 2021 10:19
@mattermod
Copy link
Contributor

Hello @manojmalik20,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

Copy link
Contributor

@hanzei hanzei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the addition 👍

@hanzei hanzei requested a review from larkox May 31, 2021 12:10
@hanzei hanzei added 2: Dev Review Requires review by a core committer 3: QA Review Requires review by a QA tester labels May 31, 2021
Copy link
Contributor

@larkox larkox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@manojmalik20
Copy link
Contributor Author

@DHaussermann Can you please review this PR?

@manojmalik20
Copy link
Contributor Author

Friendly ping @DHaussermann for review.

@DHaussermann
Copy link

DHaussermann commented Jun 14, 2021

Very sorry for the delay on this @manojmalik20 I should finally be able to get to this today 👍

@DHaussermann
Copy link

/update-branch

@mattermod
Copy link
Contributor

We don't have permissions to update this PR, please contact the submitter to apply the update.

@DHaussermann
Copy link

@hanzei or @larkox are you able to pull master into this PR branch?

@codecov-commenter
Copy link

codecov-commenter commented Jun 14, 2021

Codecov Report

Merging #448 (3870d15) into master (85343d6) will increase coverage by 0.00%.
The diff coverage is 28.57%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #448   +/-   ##
=======================================
  Coverage   19.65%   19.66%           
=======================================
  Files          11       11           
  Lines        2727     2741   +14     
=======================================
+ Hits          536      539    +3     
- Misses       2151     2162   +11     
  Partials       40       40           
Impacted Files Coverage Δ
server/plugin/api.go 7.92% <0.00%> (-0.05%) ⬇️
server/plugin/command.go 10.16% <0.00%> (-0.20%) ⬇️
server/plugin/configuration.go 28.12% <ø> (ø)
server/plugin/manifest.go 100.00% <ø> (ø)
server/plugin/template.go 95.29% <100.00%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85343d6...3870d15. Read the comment docs.

Copy link

@DHaussermann DHaussermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and passed

  • Connect to private Repositories by default functions as expected with no need to append private
  • When enabled the redundant private parameter is removed from the auto complete as expected
  • Flag to enable / disable this feature works as expected
  • Flag is false by default to ensure seamless upgrade
  • Tested on desktop and browser

LGTM!

Huge thanks @manojmalik20 for this enhancement.

@DHaussermann DHaussermann added 4: Reviews Complete All reviewers have approved the pull request and removed 3: QA Review Requires review by a QA tester labels Jun 14, 2021
@hanzei hanzei added this to the v2.1.0 milestone Jun 14, 2021
@hanzei hanzei merged commit 9355092 into mattermost:master Jun 14, 2021
@manojmalik20 manojmalik20 deleted the MI-1281 branch June 15, 2021 05:54
@manojmalik20 manojmalik20 restored the MI-1281 branch June 15, 2021 12:25
@manojmalik20 manojmalik20 deleted the MI-1281 branch June 15, 2021 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants