-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MM-36742] Fix immediately expiring request context #452
Conversation
@hanzei Does this need QA review? What would be tested? |
@DHaussermann Could you please test if the RHS infos get correctly loaded and picking an repo in the create issue modal works? |
@hanzei This resolves the list of repos not loading and it is now possible to create and attach. |
@DHaussermann Good catch. Fixed that in 93a453e. Please take another look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and passed.
- Issue with 500 responses for assignee and Repo are resolved
- Tested on desktop and browser
- Tested for create and attach
- Tested on public and private repos
LGTM!
Huge thanks @hanzei! Please merge, this will unblock 2 other PRs waiting for testing.
Summary
The caller of
createContext
needs to cancel it instead ofcreateContext
itself.Ticket Link
https://mattermost.atlassian.net/browse/MM-36742
Fixes #451