Mm 432 - Handle "unconfigured" state of plugin gracefully

[sibasankarnayak]

handled unconfigured state and allowed user to start the plugin with useful message if not configured

ticket here
#432

[mattermod]

Hello @sibasankar-demansol,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

[hanzei]

The code looks good, but maybe the UX can be a bit better. One suggestion below.

[mickmister]

Thanks @sibasankar-demansol, functionality looks good 👍

I have a few suggestions for improvement

[codecov-commenter]

Codecov Report

Merging #460 (8db8a3a) into master (bc8056e) will increase coverage by 0.24%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #460      +/-   ##
==========================================
+ Coverage   19.66%   19.90%   +0.24%     
==========================================
  Files          11       11              
  Lines        2741     3004     +263     
==========================================
+ Hits          539      598      +59     
- Misses       2162     2366     +204     
  Partials       40       40              

Impacted Files	Coverage Δ
server/plugin/command.go	9.90% <0.00%> (-0.26%)	⬇️
server/plugin/plugin.go	4.76% <ø> (-0.07%)	⬇️
server/plugin/utils.go	61.53% <0.00%> (-0.40%)	⬇️
server/plugin/template.go	95.10% <0.00%> (-0.20%)	⬇️
server/plugin/webhook.go	0.00% <0.00%> (ø)
server/plugin/manifest.go	100.00% <0.00%> (ø)
server/plugin/api.go	8.56% <0.00%> (+0.64%)	⬆️
server/plugin/subscriptions.go	10.71% <0.00%> (+0.92%)	⬆️
... and 3 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc8056e...8db8a3a. Read the comment docs.

[maisnamrajusingh]

@hanzei can you take a look at this ?

[mickmister]

Great work @sibasankar-demansol 👍 I have some non-blocking suggestions to improve some text

[mickmister]

Suggested change

	text = "Unable to fetch user details."
	text = "Error checking user's permissions"
	p.API.LogWarn(text, "err", err.Error())

[sibasankarnayak]

done

[hanzei]

Nice work 👍 One nit pick

[hanzei]

@sibasankar-demansol Let me know if you want to address my comment above. Otherwise I will just merge the PR.

[sibasankarnayak]

@sibasankar-demansol Let me know if you want to address my comment above. Otherwise I will just merge the PR.

@hanzei have made the changes as asked , you can merge it now