-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MM-50985] Remove usage of model.AppError #648
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #648 +/- ##
=======================================
Coverage 15.54% 15.54%
=======================================
Files 15 15
Lines 5476 5469 -7
=======================================
- Hits 851 850 -1
+ Misses 4582 4577 -5
+ Partials 43 42 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
if appErr != nil { | ||
return errors.Wrap(appErr, "failed check whether MM-34646 refresh is already done") | ||
var data []byte | ||
err := p.client.KV.Get(mm34646DoneKey, &data) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think we can rename this var to something else? It doesn't provide much context reading the code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To which variable are you referring?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mm34646DoneKey
@DHaussermann While there is nothing specific to test for, I would appreciate a general smoke test on the plugin functionality, as the PR touches the whole code base. |
@hanzei The plugin seems to crash when deployed from this build. I have seen this occur locally on All I did was enable the plugin or try upgrading to this build. The Local logs show the following where I see a panic (I have also attached more logs in a file in case I missed something helpful):
|
@hanzei please advise on next steps for this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and passed
- Smoke tested GitHub
- Authentication is working from browser and desktop
- Create and attach are working as expected
- Tested subscription creation and delivery
- Various slash commands to retrieve data
me
,todo
etc...
- No new error in the server logs found (just the known issue with API rate limit)
- No issues found in dev console or network tab
No regression or changes in behavior found
LGTM!
Summary
Depends on mattermost/mattermost-plugin-api#127
Ticket Link
https://mattermost.atlassian.net/browse/MM-50985