New secret rudder

[trilopin]

Summary

After some name changing, MM_RUDDER_WRITE_KEY has become MM_RUDDER_PLUGINS_PROD.

Fix custom.mk so we get the right data.

Ticket Link

no

[hanzei]

@trilopin FYI: This is another way to fix the issue: https://github.com/mattermost/mattermost-plugin-apps/blob/da73e99d66c1fd8bfad56282c55b145c8fa3076d/.github/workflows/cd.yaml#L18

[mickmister]

FYI: This is another way to fix the issue: https://github.com/mattermost/mattermost-plugin-apps/blob/da73e99d66c1fd8bfad56282c55b145c8fa3076d/.github/workflows/cd.yaml#L18

@hanzei I think we should be consistent across the projects, and so I think this PR should implement this in the workflow file as you linked, instead of editing custom.mk. @trilopin Thoughts on this?

[trilopin]

@hanzei I think we should be consistent across the projects, and so I think this PR should implement this in the workflow file as you linked, instead of editing custom.mk. @trilopin Thoughts on this?

💯 to have same solution to all repos.

I don't like to change custom.mk, but wouldn't we be making one more indirection (aka magic) by wiring MM_RUDDER_WRITE_KEY: ${{ secrets. MM_RUDDER_PLUGINS_PROD }} ? I'd understand this if we could do it just once for all plugins but it seems that we have to change all cd.yml anyway.

Is there any drawback on the custom.mk approach am I missing?