-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New secret rudder #662
New secret rudder #662
Conversation
@trilopin FYI: This is another way to fix the issue: https://github.com/mattermost/mattermost-plugin-apps/blob/da73e99d66c1fd8bfad56282c55b145c8fa3076d/.github/workflows/cd.yaml#L18 |
@hanzei I think we should be consistent across the projects, and so I think this PR should implement this in the workflow file as you linked, instead of editing |
💯 to have same solution to all repos. I don't like to change custom.mk, but wouldn't we be making one more indirection (aka magic) by wiring Is there any drawback on the custom.mk approach am I missing? |
After some name changing, MM_RUDDER_WRITE_KEY has become MM_RUDDER_PLUGINS_PROD. Fix custom.mk so we get the right data.
Summary
After some name changing, MM_RUDDER_WRITE_KEY has become MM_RUDDER_PLUGINS_PROD.
Fix custom.mk so we get the right data.
Ticket Link
no