-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MM-42918] Add debug information for setup wizard #679
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #679 +/- ##
==========================================
+ Coverage 15.46% 15.63% +0.17%
==========================================
Files 15 15
Lines 5497 5518 +21
==========================================
+ Hits 850 863 +13
- Misses 4605 4613 +8
Partials 42 42
☔ View full report in Codecov by Sentry. |
@hanzei What are the requirements to get this merged? Should some particular functionality be tested or regression tested? |
@mickmister Good question. In order to test this PR, one has to jump through a couple of hoops, namely removing the signature check for the plugin so this build can be installed as part of the onboarding flow. Once that is done, the PR can be tested. It produces output like this one: To me that is enough testing given the complex steps to get there. Are you fine with emerging the PR as it is? |
GitLab PR: mattermost/mattermost-plugin-gitlab#379 |
LGTM 👍 |
Summary
I'm unable to reproduce the issue linked in the ticket.
To debug the issue if it occurs again, I've added debug information on why exactly the wizard didn't run.
If the PR gets approved, I'm going to copy the change into https://github.com/mattermost/mattermost-plugin-gitlab.
Ticket Link
https://mattermost.atlassian.net/browse/MM-42918