-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump version to 2.1.7 #708
Bump version to 2.1.7 #708
Conversation
…notification (mattermost#697) * [MI-3405] Fix issue: improper formatting inside code block in issue created notification (#35) * [MI-3405] Fix issue: improper formatting inside code block in issue notification * [MI-3461] Add a comment to clearify the usage of code * Updated code to support less than and greater than symbols * Updated code to use html.UnescapeString * Review fix * [MI-3633] Updated logic to sanitize description only when a "<details>" tag is present in it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I would love to see a 2.2.0 soon as a lot of changes have accumulated in master
@hanzei @DHaussermann I'm wondering your thoughts on if we need a release test on this, besides the step we recently added to ensure the build runs properly on a Cloud server. cc @AayushChaudhary0001 |
I'm fine with skipping release testing on this one. |
Cool, I'll add the QA to the pipeline and we can do it whenever we get available bandwidth |
@avas27JTG I'm not sure exactly what this means. Do you mean specifically my comment about "the step we recently added to ensure the build runs properly on a Cloud server"? |
@mickmister I meant that once we are sure that it runs properly on cloud server we can perform a QA sanity to proceed with the actual release following point 5 |
@avas27JTG I've confirmed this runs correctly on a Cloud server. Merging the PR since the change is minuscule |
Summary