Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version to 2.1.7 #708

Merged
merged 2 commits into from
Nov 10, 2023

Conversation

avas27JTG
Copy link
Contributor

@avas27JTG avas27JTG commented Nov 8, 2023

…notification (mattermost#697)

* [MI-3405] Fix issue: improper formatting inside code block in issue created notification (#35)

* [MI-3405] Fix issue: improper formatting inside code block in issue notification

* [MI-3461] Add a comment to clearify the usage of code

* Updated code to support less than and greater than symbols

* Updated code to use html.UnescapeString

* Review fix

* [MI-3633] Updated logic to sanitize description only when a "<details>" tag is present in it.
Copy link
Contributor

@hanzei hanzei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I would love to see a 2.2.0 soon as a lot of changes have accumulated in master

@hanzei hanzei added the 2: Dev Review Requires review by a core committer label Nov 8, 2023
@mickmister mickmister added 3: QA Review Requires review by a QA tester and removed 2: Dev Review Requires review by a core committer labels Nov 8, 2023
@mickmister
Copy link
Member

@hanzei @DHaussermann I'm wondering your thoughts on if we need a release test on this, besides the step we recently added to ensure the build runs properly on a Cloud server. cc @AayushChaudhary0001

@hanzei
Copy link
Contributor

hanzei commented Nov 9, 2023

I'm fine with skipping release testing on this one.

@avas27JTG
Copy link
Contributor Author

I'm fine with skipping release testing on this one.

Cool, I'll add the QA to the pipeline and we can do it whenever we get available bandwidth

@mickmister
Copy link
Member

Cool, I'll add the QA to the pipeline and we can do it whenever we get available bandwidth

@avas27JTG I'm not sure exactly what this means. Do you mean specifically my comment about "the step we recently added to ensure the build runs properly on a Cloud server"?

@avas27JTG
Copy link
Contributor Author

avas27JTG commented Nov 10, 2023

Cool, I'll add the QA to the pipeline and we can do it whenever we get available bandwidth

@avas27JTG I'm not sure exactly what this means. Do you mean specifically my comment about "the step we recently added to ensure the build runs properly on a Cloud server"?

@mickmister I meant that once we are sure that it runs properly on cloud server we can perform a QA sanity to proceed with the actual release following point 5 Perform release testing of the release process.
Please let me know if we want to skip QA sanity and just cut the actual release if it works well on Cloud Server.

@mickmister
Copy link
Member

@avas27JTG I've confirmed this runs correctly on a Cloud server. Merging the PR since the change is minuscule

@mickmister mickmister merged commit aa70cf1 into mattermost:release-2.1 Nov 10, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3: QA Review Requires review by a QA tester
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants