-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GH-717] Implement subscription notification for pull request "reopened" event #718
Conversation
…equest "reopened" event.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #718 +/- ##
==========================================
+ Coverage 15.49% 15.79% +0.30%
==========================================
Files 15 15
Lines 5737 5767 +30
==========================================
+ Hits 889 911 +22
- Misses 4806 4814 +8
Partials 42 42 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, one non-blocking suggestion to clean up the existing code a bit with a switch statement
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work. 👍
@mickmister FIxed the review comments mentioned by you |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and approved
Working fine for reopened pull requests, LGTM.
…ed" event (#718) * [MI-3808] Fix issue: Subscription notification not working for pull request "reopened" event. * [MI-3808] Added test case for new template * [MI-3808] Review fix
* [GH-717] Implement subscription notification for pull request "reopened" event (#718) * [MI-3808] Fix issue: Subscription notification not working for pull request "reopened" event. * [MI-3808] Added test case for new template * [MI-3808] Review fix * bump version to 2.1.8 --------- Co-authored-by: Raghav Aggarwal <raghav.aggarwal@brightscout.com>
Summary
Screenshot:
What to test?
Steps to reproduce:
Expected behavior:
Environment:
MM version: v9.2.2
Node version: 14.18.0
Go version: 1.20.11
Ticket Link
Fixes #717