-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MM-17] Fix mention notifications and label/milestone RHS display #721
Conversation
1. Mention notifications not working. 2. Labels and milestones not getting displayed in the RHS.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #721 +/- ##
==========================================
- Coverage 15.79% 15.78% -0.01%
==========================================
Files 15 15
Lines 5767 5770 +3
==========================================
Hits 911 911
- Misses 4814 4817 +3
Partials 42 42 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, thanks @raghavaggarwal2308
@hanzei Gentle reminder for re-review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Co-authored-by: Ben Schumacher <ben.schumacher@mattermost.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested the PR for the followings,
- Labels and milestones added to a PR or issue are properly displayed in the RHS.
- Getting DM notifications from Github bot for the mentions and assigned PR and issues.
Everything is working fine, Approved.
cc @AayushChaudhary0001
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just some comments on naming from the recent LHS request feature
@mickmister Fixed the comments added by you |
Summary
What to test?
Steps to reproduce:
Ticket Link
N/A