Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MM-36] Update plugin with respect to phase 1 upgrades #727

Merged
merged 11 commits into from
Feb 15, 2024
Merged

[MM-36] Update plugin with respect to phase 1 upgrades #727

merged 11 commits into from
Feb 15, 2024

Conversation

ayusht2810
Copy link
Contributor

Summary

Updated plugin with respect to phase 1 upgrades

  • Updated Makefile
  • Updated version in nvmrc file and update package-lock.json file.
  • Updated node-sass to sass
  • Updated developer docs link in the readme file

Ticket Link

@ayusht2810 ayusht2810 self-assigned this Dec 20, 2023
@hanzei
Copy link
Contributor

hanzei commented Dec 20, 2023

@ayusht2810 Can you please merge master into your PR?

@ayusht2810
Copy link
Contributor Author

ayusht2810 commented Dec 20, 2023 •
edited

@hanzei I have kept use-branch as my base branch because this PR covers the rest of the plugin upgrades required for Phase 1. The other changes are present in the PR. Let me know your thoughts on it.

@ayusht2810 ayusht2810 added the 2: Dev Review Requires review by a core committer label Dec 20, 2023
@codecov-commenter
Copy link

codecov-commenter commented Dec 20, 2023 •
edited

Codecov Report

Attention: 81 lines in your changes are missing coverage. Please review.

Comparison is base (44f9c83) 15.85% compared to head (96081af) 15.93%.

Files Patch % Lines
build/pluginctl/logs.go 37.39% 72 Missing ⚠️
server/plugin/command.go 0.00% 5 Missing ⚠️
build/pluginctl/main.go 0.00% 4 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #727      +/-   ##
==========================================
+ Coverage   15.85%   15.93%   +0.08%     
==========================================
  Files          15       17       +2     
  Lines        5778     6018     +240     
==========================================
+ Hits          916      959      +43     
- Misses       4820     5017     +197     
  Partials       42       42

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mickmister
Copy link
Member

/update-branch

hanzei
hanzei requested changes Jan 3, 2024
View reviewed changes
Copy link
Contributor

@hanzei hanzei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One blocker, otherwise LGTM

Makefile Outdated Show resolved Hide resolved
@ayusht2810 ayusht2810 requested a review from hanzei January 3, 2024 12:51
@hanzei hanzei added the Do Not Merge Should not be merged until this label is removed label Jan 4, 2024
@hanzei
Copy link
Contributor

hanzei commented Jan 4, 2024

Let's merge #725 first.

arush-vashishtha
arush-vashishtha approved these changes Jan 4, 2024
View reviewed changes
Copy link

@arush-vashishtha arush-vashishtha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the basic flows and slash commands, everything working fine. Approved.
cc @AayushChaudhary0001

@hanzei hanzei added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core committer labels Jan 4, 2024
@hanzei hanzei added this to the v2.3.0 milestone Jan 4, 2024
lieut-data and others added 2 commits February 1, 2024 16:42
@lieut-data @mickmister @ayusht2810
Sync with playbooks: install-go-tools, gotestsum, and dynamic versions (
1df624a 
#192)

* Revert "Update main.go (#154)"

This reverts commit be4a281d0cc791d10e6e5ae917b325b2f054e475.

* Revert "[MM-33506] Use embed package to include plugin manifest (#145)"

This reverts commit ca9ee3c17c6920a636a33f378e17395afd6f329f.

* Revert "Don't generate manifest.ts (#127)"

This reverts commit 18d30b50bc7ba800c9f05bfd82970781db0aea3e.

* install-go-tools target, adopt gotestsum

* bring back make apply + automatic versioning

* Update build/manifest/main.go

Co-authored-by: Michael Kochell <6913320+mickmister@users.noreply.github.com>

* suppress git describe error when no tags match

* make version/release notes opt-in

* fix whitespace in Makefile

* document version management options

---------

Co-authored-by: Michael Kochell <6913320+mickmister@users.noreply.github.com>
@hanzei @lieut-data @ayusht2810
Fetch plugin logs from server (#193)
91a10e8 
Co-authored-by: Jesse Hallam <jesse.hallam@gmail.com>
Base automatically changed from use-public to master February 13, 2024 15:45
mickmister
mickmister approved these changes Feb 15, 2024
View reviewed changes
webapp/src/components/post_menu_action/create_issue/index.js
@@ -16,7 +16,7 @@ const mapStateToProps = (state, ownProps) => {
const systemMessage = post ? isSystemMessage(post) : true;

return {
show: state[`plugins-${pluginId}`].connected && !systemMessage,
show: state[`plugins-${manifest.id}`].connected && !systemMessage,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not required for this PR, but it would be good to always use a selector for this sort of thing, and never do this plugins-(id) thing in these files. Can this be done as part of the redux store migration?

webapp/src/components/post_menu_actions/attach_comment_to_issue/attach_comment_to_issue.jsx
@@ -26,7 +26,7 @@ export default class AttachCommentToIssuePostMenuAction extends PureComponent {
};

connectClick = () => {
window.open('/plugins/' + pluginId + '/user/connect', '_blank');
window.open('/plugins/' + manifest.id + '/user/connect', '_blank');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should really be using the server's SiteURL (not needed for this PR)

webapp/src/components/post_menu_actions/attach_comment_to_issue/attach_comment_to_issue.jsx
@@ -4,7 +4,7 @@
import React, {PureComponent} from 'react';
import PropTypes from 'prop-types';

import {id as pluginId} from '../../../manifest';
import manifest from '../../../manifest';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see sometimes we import the manifest as 'manifest' and sometimes with the relative path. Probably should just do 'manifest'

@mickmister mickmister merged commit 475c110 into master Feb 15, 2024
8 of 9 checks passed
@mickmister mickmister deleted the MM-36 branch February 15, 2024 04:27
@mattermost-build mattermost-build removed the Do Not Merge Should not be merged until this label is removed label Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mickmister mickmister mickmister approved these changes

@hanzei hanzei hanzei approved these changes

@raghavaggarwal2308 raghavaggarwal2308 raghavaggarwal2308 approved these changes

@arush-vashishtha arush-vashishtha arush-vashishtha approved these changes

@AayushChaudhary0001 AayushChaudhary0001 Awaiting requested review from AayushChaudhary0001

Assignees

@ayusht2810 ayusht2810

Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Milestone
v2.3.0
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@ayusht2810 @hanzei @codecov-commenter @mickmister @raghavaggarwal2308 @arush-vashishtha @mattermost-build @lieut-data