-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MM-166] Fix issue: decription not visible in tooltip and removed "see more" link #735
Conversation
max-height: 150px; | ||
line-height: 1.25; | ||
overflow: hidden; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What are the reasons/risks for this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mickmister This was being used to trim the description when it was too long. We modified the logic to set a max length to the description now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's still possible that it overflows though right? Is there any risk in keeping overflow: hidden
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mickmister I don't think it will overflow but there is no risk in keeping it so I have reverted the change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was it the overflow: hidden
that was making it so the description wasn't being shown at all?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mickmister No, the component ReactMarkdown
was not used properly.
@@ -118,10 +120,7 @@ export const LinkTooltip = ({href, connected, show, theme}) => { | |||
<span>{'#' + data.number}</span> | |||
</a> | |||
<div className='markdown-text mt-1 mb-1'> | |||
<ReactMarkdown | |||
source={data.body} | |||
linkTarget='_blank' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the risk in removing this linkTarget
prop?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mickmister I misunderstood the use of this prop. Added it back
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job @raghavaggarwal2308 👍 Looks good, just a few comments for discussion
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #735 +/- ##
=======================================
Coverage 15.78% 15.78%
=======================================
Files 15 15
Lines 5770 5770
=======================================
Hits 911 911
Misses 4817 4817
Partials 42 42 ☔ View full report in Codecov by Sentry. |
max-height: 150px; | ||
line-height: 1.25; | ||
overflow: hidden; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's still possible that it overflows though right? Is there any risk in keeping overflow: hidden
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR has been tested for the following scenarios:-
- Added description in the tooltip.
- Removed the "See more" link from the tooltip.
- Text gets trimmed if its length is too much.
The PR is working fine for the above conditions, LGTM. Approved.
Summary
Screenshot
What to test
Steps to test:
Ticket Link
Fixes #734