[GH-733] Updated the "issue_creations" subscription to post notification when an issue is labeled/reopened

[raghavaggarwal2308]

Summary

• Updated the "issue_creations" subscription to post a notification when an issue is labeled/reopened

Screenshots

What to test:

• Notification is getting posted when an existing issue is labeled in a channel with a subscription for issue_creations,label:"label-name"
• Notification is posted when an issue is reopened in a channel with a subscription for issue_creations

Steps to test:

1. Connect your GitHub account
2. Create a subscription for issue_creations,label:"label-name" is a channel.
3. Add a label (same as present in the subscription) to an existing issue.

Ticket Link

Fixes #733

[mickmister]

Thanks for this @raghavaggarwal2308 👍

Wondering if you would be up for also changing the string of the "person opened an issue", to include the string "with label x" when it has a label that matches a subscription in the channel

[mickmister]

Wondering if you would be up for also changing the string of the "person opened an issue", to include the string "with label x" when it has a label that matches a subscription in the channel

I think that "with label x" may need to be applied in multiple other places as well

[hanzei]

LGTM 👍

One nit pick below

[hanzei]

2/5 I like the previous code as it ensures that even when new actions are added, the code is only expected for the action open.

[raghavaggarwal2308]

@hanzei Updated

[codecov-commenter]

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (2608197) 15.78% compared to head (7a5fc82) 15.78%.

Files	Patch %	Lines
server/plugin/command.go	50.00%	1 Missing ⚠️
server/plugin/webhook.go	0.00%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #736   +/-   ##
=======================================
  Coverage   15.78%   15.78%           
=======================================
  Files          15       15           
  Lines        5770     5770           
=======================================
  Hits          911      911           
  Misses       4817     4817           
  Partials       42       42           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[raghavaggarwal2308]

Wondering if you would be up for also changing the string of the "person opened an issue", to include the string "with label x" when it has a label that matches a subscription in the channel

@mickmister Sure, I will make the change

[mickmister]

@raghavaggarwal2308 We can do the above change in a separate PR. Created an issue for this here #742

[AayushChaudhary0001]

This PR has been tested for the following scenarios:-

• Notification sent to the user in the subscribed channel for desired label added on an issue.
• Notification sent to the user in the subscribed channel when an issue is opened for "issue_creation" subscription.

The PR was working fine for both the above conditions, LGTM. Approved.