[MM-352] Add feature to publish release create and delete events #762

ayusht2810 · 2024-04-05T08:22:15Z

Summary

Added feature to publish release create and delete events

Screenshot

Ticket Link

Fixes #723

What to test?

Update the webhook for the repo to receive notifications for release events
Create a subscription for a repo with a subscription enabled for release events
Create and delete a release on the subscribed repo
Check for the events received in the subscribed channel

Checklist

Completed dev testing
make test Ran test cases and ensured they are passing
make check-style Ran style check and ensured both webapp and server pass the checks

hanzei

Nice work 👍

A few questions below

hanzei · 2024-04-05T14:51:37Z

README.md

@@ -95,7 +95,7 @@ As a system admin, you must create a webhook for each organization you want to r
   - **Content Type:** `application/json`
   - **Secret:** the webhook secret you copied previously.
 6. Select **Let me select individual events** for "Which events would you like to trigger this webhook?".
-7. Select the following events: `Branch or Tag creation`, `Branch or Tag deletion`, `Issue comments`, `Issues`, `Pull requests`, `Pull request review`, `Pull request review comments`, `Pushes`, `Stars`.
+7. Select the following events: `Branch or Tag creation`, `Branch or Tag deletion`, `Issue comments`, `Issues`, `Pull requests`, `Pull request review`, `Pull request review comments`, `Pushes`, `Stars`, `Releases`.


The changelog should mention that GH admins need to update their hooks.

@ayusht2810 Do you have a suggestion where we could store that notice?

@hanzei We can manually update release notes to have that changelog or create a separate PR for this change to have a changelog for it. What is your opinion on this?

Release notes are essentially the changelog for plugin releases

We have Branch or Tag creation already. Isn't that about the same as releases? I'm actually not sure if that tag creation feature works properly

server/plugin/template.go

hanzei · 2024-04-05T14:53:00Z

server/plugin/template.go

+{{- if eq .GetAction "created" }} created a release {{template "release" .GetRelease}}
+{{- else if eq .GetAction "deleted" }} deleted a release {{template "release" .GetRelease}}


Are there any other actions besides these two?

Yes the other events are:

Release created

Release edited

Release published

Release unpublished

Release deleted

server/plugin/webhook.go

raghavaggarwal2308

LGTM, other than @hanzei comments above

mickmister · 2024-04-22T14:45:56Z

README.md

@@ -95,7 +95,7 @@ As a system admin, you must create a webhook for each organization you want to r
   - **Content Type:** `application/json`
   - **Secret:** the webhook secret you copied previously.
 6. Select **Let me select individual events** for "Which events would you like to trigger this webhook?".
-7. Select the following events: `Branch or Tag creation`, `Branch or Tag deletion`, `Issue comments`, `Issues`, `Pull requests`, `Pull request review`, `Pull request review comments`, `Pushes`, `Stars`.
+7. Select the following events: `Branch or Tag creation`, `Branch or Tag deletion`, `Issue comments`, `Issues`, `Pull requests`, `Pull request review`, `Pull request review comments`, `Pushes`, `Stars`, `Releases`.


We have Branch or Tag creation already. Isn't that about the same as releases? I'm actually not sure if that tag creation feature works properly

ayusht2810 · 2024-04-24T11:33:50Z

@mickmister I tested the tag feature by pushing a tag on a test repo, and I was able to get the message for the pushed tag.

We have Branch or Tag creation already. Isn't that about the same as releases?

Branch or Tag creation sends events only when branches or tags are created, for release events, we need to select other event mentioned in the screenshot below

hanzei

🚀

AayushChaudhary0001

The above PR has been tested for the following scenarios:-

Notification for creating a release
Notification for deleting a release

The PR was working fine for both the conditions, LGTM. Approved.

* update github docs for mattermost/mattermost-plugin-github#762 * update zoom plugin docs for mattermost/mattermost-plugin-zoom#375 * improvements to github plugin page * remove todo comment --------- Co-authored-by: Carrie Warner (Mattermost) <74422101+cwarnermm@users.noreply.github.com>

ayusht2810 added 2 commits April 5, 2024 13:45

[MM-352] Add feature to publish release create and delete events

2e1faf0

[MM-352] Update readme for updated webhook events

7a389b3

ayusht2810 requested review from hanzei and mickmister as code owners April 5, 2024 08:22

ayusht2810 requested a review from raghavaggarwal2308 April 5, 2024 09:19

ayusht2810 self-assigned this Apr 5, 2024

ayusht2810 added the 2: Dev Review Requires review by a core committer label Apr 5, 2024

hanzei requested changes Apr 5, 2024

View reviewed changes

ayusht2810 added 2 commits April 8, 2024 12:42

[MM-352] Update logic of creating post for the release events

22b4e6d

[MM-352] Update indentation in template

b571359

ayusht2810 requested a review from hanzei April 8, 2024 07:21

[MM-352] Add release event in command help text

28fab41

raghavaggarwal2308 approved these changes Apr 9, 2024

View reviewed changes

mickmister approved these changes Apr 22, 2024

View reviewed changes

hanzei approved these changes Apr 30, 2024

View reviewed changes

hanzei requested a review from AayushChaudhary0001 April 30, 2024 11:08

hanzei added 3: QA Review Requires review by a QA tester and removed 2: Dev Review Requires review by a core committer labels Apr 30, 2024

AayushChaudhary0001 approved these changes May 9, 2024

View reviewed changes

mickmister added 4: Reviews Complete All reviewers have approved the pull request and removed 3: QA Review Requires review by a QA tester labels May 14, 2024

mickmister merged commit 2056a77 into master May 14, 2024
9 checks passed

mickmister deleted the MM-352 branch May 14, 2024 21:57

mickmister added a commit to mattermost/docs that referenced this pull request May 20, 2024

update github docs for mattermost/mattermost-plugin-github#762

a282fbe

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[MM-352] Add feature to publish release create and delete events #762

[MM-352] Add feature to publish release create and delete events #762

ayusht2810 commented Apr 5, 2024

hanzei left a comment

hanzei Apr 5, 2024

ayusht2810 Apr 8, 2024 •

edited

Loading

mickmister Apr 22, 2024

mickmister Apr 22, 2024

hanzei Apr 5, 2024

ayusht2810 Apr 8, 2024

raghavaggarwal2308 left a comment

mickmister Apr 22, 2024

ayusht2810 commented Apr 24, 2024

hanzei left a comment

AayushChaudhary0001 left a comment

		{{- if eq .GetAction "created" }} created a release {{template "release" .GetRelease}}
		{{- else if eq .GetAction "deleted" }} deleted a release {{template "release" .GetRelease}}

[MM-352] Add feature to publish release create and delete events #762

[MM-352] Add feature to publish release create and delete events #762

Conversation

ayusht2810 commented Apr 5, 2024

Summary

Screenshot

Ticket Link

What to test?

Checklist

hanzei left a comment

Choose a reason for hiding this comment

hanzei Apr 5, 2024

Choose a reason for hiding this comment

ayusht2810 Apr 8, 2024 • edited Loading

Choose a reason for hiding this comment

mickmister Apr 22, 2024

Choose a reason for hiding this comment

mickmister Apr 22, 2024

Choose a reason for hiding this comment

hanzei Apr 5, 2024

Choose a reason for hiding this comment

ayusht2810 Apr 8, 2024

Choose a reason for hiding this comment

raghavaggarwal2308 left a comment

Choose a reason for hiding this comment

mickmister Apr 22, 2024

Choose a reason for hiding this comment

ayusht2810 commented Apr 24, 2024

hanzei left a comment

Choose a reason for hiding this comment

AayushChaudhary0001 left a comment

Choose a reason for hiding this comment

ayusht2810 Apr 8, 2024 •

edited

Loading