Updates go-github to v54 for projects v2 support #771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanzei
requested changes
Apr 29, 2024
mickmister
approved these changes
Apr 29, 2024
mickmister
added
4: Reviews Complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR bumps up the major version of the google/go-github dependency from v41 to v54.
While this isn't the latest version, it is the first version that introduces support for the Projects v2 API that could be used in creating subscriptions #409.
The only breaking change I could identify was the use of a new wrapper datatype Timestamp, where previously time.Time was being used.
I don't have my E2E tests setup locally yet but can review the CI run when a maintainer allows it.
Ticket Link