Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GH-449] Fix DM notification messages #511

Merged
merged 1 commit into from
Nov 28, 2024
Merged

[GH-449] Fix DM notification messages #511

merged 1 commit into from
Nov 28, 2024

Conversation

raghavaggarwal2308
Copy link
Contributor

Summary

  • Fix DM notification messages
  • Earlier the merge request number was getting blended inside the repo name

Screenshot:

Earlier:
image

Now:
image

What to test:

  • Getting proper DM notifications for events on Gitlab

How to test:

  • Connect you Gitlab account.
  • Setup webhook
  • Trigger the desired event from GItlab.

Ticket Link

Fixes #449

@raghavaggarwal2308 raghavaggarwal2308 self-assigned this Jul 17, 2024
wiggin77
wiggin77 approved these changes Jul 31, 2024
View reviewed changes
Copy link
Member

@wiggin77 wiggin77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@hanzei hanzei added 2: Dev Review Requires review by a core committer 3: QA Review Requires review by a QA tester labels Jul 31, 2024
@raghavaggarwal2308 raghavaggarwal2308 added this to the v1.10.0 milestone Nov 22, 2024
arush-vashishtha
arush-vashishtha approved these changes Nov 25, 2024
View reviewed changes
Copy link

@arush-vashishtha arush-vashishtha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has been tested and the DM message has been verified according to the updates. LGTM.

@raghavaggarwal2308 raghavaggarwal2308 added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core committer 3: QA Review Requires review by a QA tester labels Nov 28, 2024
@raghavaggarwal2308 raghavaggarwal2308 merged commit 72b6843 into master Nov 28, 2024
7 checks passed
@raghavaggarwal2308 raghavaggarwal2308 deleted the MM-449 branch November 28, 2024 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wiggin77 wiggin77 wiggin77 approved these changes

@ayusht2810 ayusht2810 ayusht2810 approved these changes

@arush-vashishtha arush-vashishtha arush-vashishtha approved these changes

@mickmister mickmister Awaiting requested review from mickmister

@spirosoik spirosoik Awaiting requested review from spirosoik spirosoik is a code owner

@AayushChaudhary0001 AayushChaudhary0001 Awaiting requested review from AayushChaudhary0001

Assignees

@raghavaggarwal2308 raghavaggarwal2308

Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Milestone
v1.10.0
Development

Successfully merging this pull request may close these issues.

Enhancement in the text of notification for the change of assignee in MRs of Gitlab in the DM on MM.
5 participants
@raghavaggarwal2308 @wiggin77 @ayusht2810 @arush-vashishtha @hanzei