Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GH-604]: Feature to create a subscription template for Jira subscriptions. #897

Open
wants to merge 16 commits into
base: master
Choose a base branch
from
Open

[GH-604]: Feature to create a subscription template for Jira subscriptions. #897

wants to merge 16 commits into from

Conversation

Kshitij-Katiyar
Copy link
Contributor

@Kshitij-Katiyar Kshitij-Katiyar commented Dec 13, 2022 •
edited by hanzei
Loading

Summary

  • This PR added the feature to create subscription templates and use them to create Jira subscriptions. So if a Mattermost user needs to create each channel subscription from scratch. This can be cumbersome, especially when there is plenty of duplicated settings across subscriptions. Now, we can instead have a subscription template feature that allows us to create a shell for a subscription, which can then be selected when creating a new subscription.
  • Each template is associated with a given Jira project. This is because each project's issue schemas can be a bit different, which is why we have associated subscriptions to a single project.
  • This PR contains all the changes from Pr #783 So this PR alone is enough to fix this issue so we can close Pr #783 afterward.

Issue

Kshitij-Katiyar and others added 3 commits December 13, 2022 16:48
@Kshitij-Katiyar @sanjaydemansol
[MI-2353]:Updated create,get and delete subscription template APIs (#16)
30ee12c 
* before changes to tests

* Lint and Test fixes

* removed LogDebug messages

* removed unused value

* Merge remote-tracking branch 'upstream/master' into issue-604

* removed unwanted change

* [MI-2353]:Updated create,get and delete subscription template APIs

* [MI-2353]:Fixed review fixes

* [MI-2353]:Fixed review comments

* [MI-2353]:Fixed review fixes

* [MI-2353]:Added model constants

* [MI-2369]:Created edit and get subscription template API (#17)

* [MI-2369]:Created edit and get subscription template API

* [MI-2369]:Fixed review fixes

* [MI-2369]:added a condition

Co-authored-by: Sanjay <sanjaymj@12345>
Co-authored-by: sanjaydemansol <85980820+sanjaydemansol@users.noreply.github.com>
Co-authored-by: sibasankarnayak <sibasankar@demansoltech.com>
@Kshitij-Katiyar
[MM-604]:Integrated frontend code
c3bda77
@Kshitij-Katiyar
[MM-604]:Fixed test cases
cafc8c5
@mattermod
Copy link
Contributor

Hello @Kshitij-Katiyar,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

@codecov-commenter
Copy link

codecov-commenter commented Dec 15, 2022 •
edited
Loading

Codecov Report

Attention: Patch coverage is 59.10781% with 110 lines in your changes missing coverage. Please review.

Project coverage is 30.69%. Comparing base (3d90500) to head (eec7f78).
Report is 9 commits behind head on master.

❗ Current head eec7f78 differs from pull request most recent head 3935623

Please upload reports for the commit 3935623 to get more accurate results.

Files Patch % Lines
server/subscribe.go 58.17% 88 Missing and 22 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #897      +/-   ##
==========================================
- Coverage   33.37%   30.69%   -2.69%     
==========================================
  Files          53       52       -1     
  Lines        8008     8061      +53     
==========================================
- Hits         2673     2474     -199     
- Misses       5112     5370     +258     
+ Partials      223      217       -6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mattermod
Copy link
Contributor

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

@mickmister mickmister mentioned this pull request Feb 1, 2023
Closed
@hanzei hanzei added 2: Dev Review Requires review by a core committer 3: QA Review Requires review by a QA tester Lifecycle/frozen and removed Lifecycle/1:stale 2: Dev Review Requires review by a core committer 3: QA Review Requires review by a QA tester labels Feb 22, 2023
@hanzei
Copy link
Collaborator

hanzei commented Feb 22, 2023

Let's put this in the icebox as it will conflict with other work

@hanzei hanzei removed the request for review from mickmister May 21, 2023 07:33
@mickmister
Copy link
Contributor

@Kshitij-Katiyar Can you please provide some screenshots of this PR in action?

@mickmister mickmister mentioned this pull request Aug 24, 2023
Merged
@hanzei hanzei added the Work In Progress Not yet ready for review label Sep 1, 2023
@Kshitij-Katiyar
Copy link
Contributor Author

@mickmister Some screenshots of the feature
Screenshot from 2023-09-13 17-46-57
Screenshot from 2023-09-13 17-48-43
Screenshot from 2023-09-13 17-49-01
Screenshot from 2023-09-13 17-49-15
Screenshot from 2023-09-13 17-49-29
Screenshot from 2023-09-13 17-49-35

mickmister
mickmister reviewed Nov 30, 2023
View reviewed changes
Copy link
Contributor

@mickmister mickmister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Kshitij-Katiyar, apologies for the late comment here. I did a quick review over the PR and left a few comments. I can give a more in-depth review once they can be addressed

webapp/src/actions/index.ts Outdated Show resolved Hide resolved
server/subscribe.go Outdated Show resolved Hide resolved
server/subscribe.go Show resolved Hide resolved
@mickmister
Copy link
Contributor

Thanks for the work on this btw. This will have a big impact on the workflow of using subscriptions across a team

@mickmister mickmister removed their request for review July 10, 2024 05:34
@raghavaggarwal2308 raghavaggarwal2308 added this to the v4.3.0 milestone Sep 18, 2024
@raghavaggarwal2308 raghavaggarwal2308 added 2: Dev Review Requires review by a core committer 3: QA Review Requires review by a QA tester and removed Lifecycle/frozen Work In Progress Not yet ready for review Contributor labels Sep 21, 2024
@wiggin77
Copy link
Member

/update-branch

@mattermost-build
Copy link
Contributor

We don't have permissions to update this PR, please contact the submitter to apply the update.

@Kshitij-Katiyar
Copy link
Contributor Author

@wiggin77 I have synced the branch with the master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raghavaggarwal2308 raghavaggarwal2308 raghavaggarwal2308 left review comments

@mickmister mickmister mickmister left review comments

@wiggin77 wiggin77 wiggin77 approved these changes

@fmartingr fmartingr Awaiting requested review from fmartingr

Assignees

@Kshitij-Katiyar Kshitij-Katiyar

Labels
2: Dev Review Requires review by a core committer 3: QA Review Requires review by a QA tester
Projects
None yet
Milestone
v4.3.0
Development

Successfully merging this pull request may close these issues.

Feature to create a subscription template
9 participants
@Kshitij-Katiyar @mattermod @codecov-commenter @hanzei @mickmister @wiggin77 @mattermost-build @fmartingr @raghavaggarwal2308